Skip to content

Fix Applying indicator and jobMonitor notifications #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2025

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented May 15, 2025

Makes the Applying indicator in the left menu accurately show when there is an apply operation in process, such as when managing the game for the first time.

  • Added a job for the Synchronize operation so we can track it
  • Fixed a bug with the HasActiveJob method not returning notifications due to missing initial State values
  • Fixed a bug with a rare path in create loadout that was applying the wrong lodout
  • Use the SynchronizerService Synchronize method inside CreateLoadout to have tracking
  • Some comments and readability cleanup

@Al12rs Al12rs requested a review from a team May 15, 2025 11:03
@Al12rs Al12rs added this to MVP May 15, 2025
@Al12rs Al12rs moved this to Review in MVP May 15, 2025
@Al12rs Al12rs self-assigned this May 15, 2025
@Al12rs Al12rs force-pushed the fix-missing-apply-button branch from dc51d45 to 01de3d7 Compare May 19, 2025 11:03
@Al12rs Al12rs merged commit db510f8 into main May 19, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in MVP May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants