test: symbiotic DefaultStakerRewards fork #1503
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackstar
force-pushed
the
docs/symbiotic-integration
branch
17 times, most recently
from
73edbeb to
2634730
Compare
* SBMockVault * SBMockRegistry * SBMockNetworkMiddlewareService
rackstar
force-pushed
the
docs/symbiotic-integration
branch
from
2634730 to
db4e995
Compare
rackstar
changed the base branch from
release-candidate
to
feat/symbiotic-vault-rewards-contracts
rackstar
commented
Dec 10, 2025
Comment on lines
-115
to
+119
| uint256 rewardsToClaim = Math.min(maxRewards, rewardsByTokenNetwork.length - rewardIndex); | ||
| uint256 processed; | ||
|
|
||
| for (uint256 i; i < rewardsToClaim; ) { | ||
| // loop until we hit maxRewards or run out of reward distributions | ||
| while (processed < maxRewards && rewardIndex < rewardsByTokenNetwork.length) { |
Contributor
Author
There was a problem hiding this comment.
had drop the Math.min and change to while loop to avoid stack too deep error
rackstar
changed the title
rackstar
force-pushed
the
docs/symbiotic-integration
branch
2 times, most recently
from
3a705d9 to
329c934
Compare
rackstar
force-pushed
the
docs/symbiotic-integration
branch
4 times, most recently
from
90d2388 to
a9415c2
Compare
rackstar
force-pushed
the
docs/symbiotic-integration
branch
from
a9415c2 to
0dbae38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
withdrawalShares[nextEpoch]to eligible shares for rewards along withactiveStakeShareswithdrawalShares[currentEpoch]is NOT eligible shares for rewardsTesting
unit tests
Checklist