Adds feature to Edit Custom certificates.

[rumansaleem]

Closes #1618 & #1911

• Adds a PUT API to update certificate data (using only nice_name for now). The method to call this API already existed in client-side.
• Updates the existing Form UI & Logic:
  • Conditionally calls updating or creating a certificate.
  • Makes certificates non-required in case of editing
  • Existing API call to upload files to existing certificate, replaces the existing files, in case files already exists.

Screenshots

Edit Menu (only for custom certificates)

Edit Form (re-uses existing form)

[rumansaleem]

Hey @jc21 can you please review this PR?

[asmwp]

I have tried to use this version of NPM and pulled the docker image. When running this in Docker on Ubuntu using Firefox 138.0.4 (64-bit) when I go to add an SSL and select 'Custom' I get javascript errors 'InternalError: too much recursion - in main.bundle.js related to this line isNew http://0.0.0.0:81/js/17.bundle.17.js?v=2.12.3:1'. Have tried clearing cache etc, no good.

[rumansaleem]

hey @asmwp thanks for looking at this. I will look into this and get back with the fix.

[rumansaleem]

I've fixed the issue, I thought this.isNew() inside a template function would refer to model function (new to backbone.js 😅). Fixed by directly checking id. Create and Edit both features seems to work as expected now.

@asmwp can you have another look?

[nginxproxymanagerci]

Docker Image for build 3 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4425

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

[asmwp]

I didn't think it was working earlier but it was me being an idiot! I can confirm that this now works as expected in both Chrome and Firefox on Ubuntu.

[rjblake]

nginxproxymanager/nginx-proxy-manager-dev:pr-4425

Same for me. Don't forget to clear your cache/empty cache & hard reload. You'll see the Edit option after that. Much appreciated @rumansaleem