-
Notifications
You must be signed in to change notification settings - Fork 221
feat: cosmos v50 upgrade #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: cosmos v50 upgrade #2308
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 171 files out of 278 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the codebase to Cosmos v50 by updating dependencies, import paths, and adapting to new API signatures provided by the upgraded libraries. Key changes include revising test dependency constructors to require a temporary directory, modifying module keeper and gas meter API calls, and updating proto-generated files for tokenfactory and sudo modules.
Reviewed Changes
Copilot reviewed 265 out of 265 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
app/evmante/evmante_can_transfer_test.go | Updated test dependency initialization with TempDir argument |
app/app_config.go | Revised import paths and removed legacy dependencies |
app/app.go | Updated app builder calls, module registration, and API service register |
app/ante/* | Adjustments to test utilities, gas meter types, and ante logic |
api/nibiru/tokenfactory/v1/tx.pulsar.go and others | Regeneration of proto descriptors reflecting new API requirements |
Comments suppressed due to low confidence (1)
app/ante/fixed_gas_test.go:201
- The expected gas value was updated from 67193 to 76885; confirm that this change reflects the intended behavior of the upgraded gas meter in Cosmos v50.
expectedGas: 76885,
@@ -327,27 +324,37 @@ func NewNibiruApp( | |||
); err != nil { | |||
panic(err) | |||
} | |||
app.App = appBuilder.Build(logger, db, traceStore, baseAppOptions...) | |||
app.App = appBuilder.Build(db, traceStore, baseAppOptions...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logger parameter has been removed from the Build call; please update related documentation or inline comments to clarify this API change for future maintainers.
Copilot uses AI. Check for mistakes.
523d709
to
9bb1f14
Compare
…/nibiru into expertdicer/feat/v50
Purpose / Abstract