Skip to content

feat: cosmos v50 upgrade #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

feat: cosmos v50 upgrade #2308

wants to merge 73 commits into from

Conversation

expertdicer
Copy link
Contributor

Purpose / Abstract

  • Closes #AAA

Copy link
Contributor

coderabbitai bot commented May 5, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

171 files out of 278 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@expertdicer expertdicer marked this pull request as ready for review May 19, 2025 09:28
@expertdicer expertdicer requested a review from a team as a code owner May 19, 2025 09:28
@matthiasmatt matthiasmatt requested a review from Copilot May 20, 2025 15:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the codebase to Cosmos v50 by updating dependencies, import paths, and adapting to new API signatures provided by the upgraded libraries. Key changes include revising test dependency constructors to require a temporary directory, modifying module keeper and gas meter API calls, and updating proto-generated files for tokenfactory and sudo modules.

Reviewed Changes

Copilot reviewed 265 out of 265 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/evmante/evmante_can_transfer_test.go Updated test dependency initialization with TempDir argument
app/app_config.go Revised import paths and removed legacy dependencies
app/app.go Updated app builder calls, module registration, and API service register
app/ante/* Adjustments to test utilities, gas meter types, and ante logic
api/nibiru/tokenfactory/v1/tx.pulsar.go and others Regeneration of proto descriptors reflecting new API requirements
Comments suppressed due to low confidence (1)

app/ante/fixed_gas_test.go:201

  • The expected gas value was updated from 67193 to 76885; confirm that this change reflects the intended behavior of the upgraded gas meter in Cosmos v50.
expectedGas: 76885,

@@ -327,27 +324,37 @@ func NewNibiruApp(
); err != nil {
panic(err)
}
app.App = appBuilder.Build(logger, db, traceStore, baseAppOptions...)
app.App = appBuilder.Build(db, traceStore, baseAppOptions...)
Copy link
Preview

Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logger parameter has been removed from the Build call; please update related documentation or inline comments to clarify this API change for future maintainers.

Copilot uses AI. Check for mistakes.

@expertdicer expertdicer force-pushed the expertdicer/feat/v50 branch from 523d709 to 9bb1f14 Compare May 27, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant