v3.0.3 20240227 [Hotfix issue] #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- BE: PDF Merged failed when upload file more than 2 ---
ProcessID : f415bded-5042-4fee-bef1-e11022dbfd23
Payload:
* _token: TOKEN
* batch: false
* file[0]: Modul-Konsep-Perangkat-Lunak.pdf
Environment : Production
Step to reproduce :
- User klik menu merge
- User pilih file PDF yang ingin diberi watermark
- User klik button merge pdf,dan muncul error
Submitter : @StevanusAndika
Root cause :
- Wrong dropzone logic that was set for merge PDF, merge PDF should use multiple dropzone area.
It causing file that was send in the payload always single file, not batch or multiple. Then return error ;
This task can't be processed. Check why in the params. (For merging PDF we need at least 2 PDF files.)
That indicate file that send to API only one (Same explaination from payload)
Resolution :
- Properly guard merge process when user upload file less than 2 files, then that are not allowed to process then show error notifications
- Properly set dropzone multiple that was used for compress and convert to handle merge process too
--- BE: PDF Watermark Error ---
ProcessID :38de7240-3d0a-485d-ab40-ed681df39bc0
Environment : Production
Step to reproduce :
- User klik menu watermark PDF
- User memilih / drag and drop file pdf yang ingin diberi watermark
- User memilih Watermark Options(dalam kasus ini adalah text)
- User mengisi semua parameter yang dibutuhkan
- User klik button watermark PDF ,dan muncul error seperti pada error info dan error Id
Submitter : @StevanusAndika
Root cause :
- WatermarkTransparency has 2 ID in the same layout, although it already define with different call on variable, but it has another issue when try to get actual value from transparency.
Due this duplicate id, transparency value are always locked at 100%, except when both on that transparency has changed
- AddFile logic for watermarktask are not in correct order, so it can lead fileDamage issue when file was uploaded before thumbnail or text that want to set as watermark
Resolution :
- Properly split and create separate IDs for watermark font and watermark text transparency value [Reflecting change on kao-logic and kao-controller]
- Re-order addfile logic for watermarktask
--- BE: Unsupported file format! watermark PDF Images ---
ProcessID : -
Environment : Production
Step to reproduce :
- User klik menu watermark
- User pilih file PDF yang ingin diberi watermark
- User pilih Watermark Options(dalam hal ini adalah image)
- User pilih file gambar yang ingin dijadikan watermark
- User mengisi semua parameter yang dibutuhkan
- User klik button watermark PDF dan muncul error seperti pada error info
Submitter : @StevanusAndika
Root cause : Logic for file extension limit image file are not set properly…
Resolution : Properly re-condition for file extension guard to allow some of images file
Signed-off-by: Dicky Herlambang (花） <[email protected]>
Signed-off-by: Dicky Herlambang (花） <[email protected]>
Nicklas373
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: