Add duplicate-file-open prevention ability #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It's not a bad idea, but this won't work if a file is opened in a way other than using the filemanager. People might be annoyed at this type of change without it being behind an option (although I personally don't care). It's minor, but someone might open 1 file side-by-side, which this doesn't allow for. |
sum01
reviewed
Feb 3, 2020
| end | ||
|
|
||
| -- Store a reference to the last opened file | ||
| open_files ={} |
Collaborator
There was a problem hiding this comment.
Make this local open_files = {} to avoid conflicts outside of the plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this will not work properly if files are opened before the plugin is initialized as it cannot track them.