-
Notifications
You must be signed in to change notification settings - Fork 4
GPCare related changes #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
NictizEduard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik heb twee twijfels en een check of jij dit bewust hebt toegevoegd, @LuudSlagter
| <extension url="http://hl7.org/fhir/StructureDefinition/elementdefinition-bindingName"> | ||
| <valueString value="PractitionerSpecialty" /> | ||
| </extension> | ||
| <strength value="required" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik heb mijn twijfels of we dit (nu al) op required moeten zetten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Het zit wel op een aparte slice, dus in die zin kan het niet veel kwaad. Maar als we later nog updates willen doen is het misschien beter de binding wat flexibeler te maken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daar heb je inderdaad wel een goed punt dat het slice specifiek is, dus dan kan het niet veel kwaad.
| <extension url="http://hl7.org/fhir/StructureDefinition/elementdefinition-bindingName"> | ||
| <valueString value="OrganizationType" /> | ||
| </extension> | ||
| <strength value="required" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik heb mijn twijfels of we dit (nu al) op required moeten zetten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daar heb je inderdaad wel een goed punt dat het slice specifiek is, dus dan kan het niet veel kwaad.
| <element id="Organization.partOf"> | ||
| <path value="Organization.partOf" /> | ||
| <type> | ||
| <extension url="http://hl7.org/fhir/StructureDefinition/structuredefinition-hierarchy"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heb je dit bewust toegevoegd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit is zo'n Forge-artifact wat is toegevoegd na resaven (die dingen heb ik in een aparte commit toegevoegd, zodat we die eventueel makkelijk terug kunnen draaien).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top, duidelijk.
NictizEduard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuudSlagter akkoord met PR.
| <extension url="http://hl7.org/fhir/StructureDefinition/elementdefinition-bindingName"> | ||
| <valueString value="OrganizationType" /> | ||
| </extension> | ||
| <strength value="required" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daar heb je inderdaad wel een goed punt dat het slice specifiek is, dus dan kan het niet veel kwaad.
| <identity value="ART-DECOR-hg" /> | ||
| <uri value="https://decor.nictiz.nl/ad/#/hg-/datasets/dataset/2.16.840.1.113883.2.4.3.11.60.103.1.1/2020-10-19T17:52:39" /> | ||
| <name value="Huisarts- en paramedische overdrachten" /> | ||
| <comment value="This is a preliminary mapping that should not be used for immediate implementation." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De comment is misschien onwenselijk om in nl-core te plaatsen. Mogelijk moeten we de nl-core-mappings pas doen als we er meer zeker van zijn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De eisen aan de naamgeving zijn opgenomen in de profiling guidelines: https://informatiestandaarden.nictiz.nl/wiki/FHIR:V1.0_FHIR_Profiling_Guidelines_R4#Associating_the_functional_definition_to_StructureDefinitions
| <fhirVersion value="4.0.1" /> | ||
| <mapping> | ||
| <identity value="ART-DECOR-hg" /> | ||
| <uri value="https://decor.nictiz.nl/ad/#/hg-/datasets/dataset/2.16.840.1.113883.2.4.3.11.60.103.1.1/2020-10-19T17:52:39" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De uri willen we uiteindelijk laten verwijzen naar de publicatie van ART-DECOR, deze gaat naar de live-versie.
| <element id="Patient.name"> | ||
| <path value="Patient.name" /> | ||
| <type> | ||
| <code value="HumanName" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waarom verdwijnt dit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forge?
| <map value="hg-dataelement-1677" /> | ||
| <comment value="Contactpersoon" /> | ||
| </mapping> | ||
| </element> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik ken de context niet, maar let even goed op het verschil tussen Patient.contact en RelatedPerson. De eerste gaat alleen over de "persoon waarmee contact gezocht moet worden als er iets is met de patient".
No description provided.