Conversation
|
Since there are no automated tests or CI/CD, did you verify if the training scripts still work correctly? It would be essential if they do, as this is the primary usage of the repo (i.e. model building) thus far. |
|
Yeah. I haven't tested that. Will get to it. |
|
okay, you'll be entering researchy code, but you should be able to pull all the data & at least see if you enter the first epoch. Ensure you have the repos checked out correctly as in https://github.com/Niger-Volta-LTI/yoruba-adr/blob/master/src/aggregate_corpora_make_parallel_text.py#L22 If it doesn't work, it may be best to separate concerns (1) ensure training isn't broken (2) deploy |
|
How about the easier alternative of keeping two branches. |
|
Sounds good, I'll make a new branch as you suggest |
|
new branch here: https://github.com/Niger-Volta-LTI/yoruba-adr/tree/sagemaker-deployment mirroring yours @ Olamyy |
I removed the ONMT folder and added it to the requirements.txt