Skip to content

(docs) update README.md - #121

Open
vladdoster wants to merge 1 commit into
Nike-Inc:masterfrom
vladdoster:vladdoster-patch-1
Open

(docs) update README.md#121
vladdoster wants to merge 1 commit into
Nike-Inc:masterfrom
vladdoster:vladdoster-patch-1

Conversation

@vladdoster

Copy link
Copy Markdown
  • fix grammar
  • fix spelling
  • increase readability for a non-native speaker (me)

- fix grammar
- fix spelling
- increase readability for a non-native speaker (me)
@vladdoster
vladdoster requested a review from a team as a code owner January 21, 2021 08:56

@venky526 venky526 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

Comment thread README.md

If you want to know about the available actions you can take with your new
CLI you can always the `--help` command.
If you want to know about the available actions, you can take with your new

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comma should not be added.

@vladdoster vladdoster Jan 26, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrduncans jrduncans Jan 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that "you can take with your new CLI" is not an independent clause. The "with" is meaningless without the first part, because the noun phrase is actually "the available actions you can take with your new CLI" with "actions" being the object of the preposition "about" in the conditional clause "If you want to know about...".

It's really the whole thing up to "CLI" that is the introductory clause; the independent clause is "you can always use the --help command".

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrduncans Ah okay, that makes sense. I appreciate the thorough explanation. I am reverting this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants