Fix GoogleParser first-child selector problem.#131
Open
kcy1019 wants to merge 1 commit intoNikolaiT:masterfrom
kcy1019:master
Open
Fix GoogleParser first-child selector problem.#131kcy1019 wants to merge 1 commit intoNikolaiT:masterfrom kcy1019:master
kcy1019 wants to merge 1 commit intoNikolaiT:masterfrom
kcy1019:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, the GoogleParser can't parse results of files like these:
[PDF]david singer (LoA).pdf
home.sogang.ac.kr/.../david%20singer%20(LoA).pd...
In this case, since <span class="_ogd b w xsm">[PDF]</span> is the first child and <a href="..."> is the second child, the parser can't parse the link. However, w/o first-child works very well in both cases(file and non-file cases). I think this is somewhat redundant and should be removed.