Skip to content

Stop onDropDownClose from firing when dropdown already closed #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rooby wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Stop onDropDownClose from firing when dropdown already closed #246

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5b97c1b
Stop the onDropDownClose event from firing when the dropdown is alrea…
rooby Jun 24, 2020
b5bc59f
Revert unwanted quote change
rooby Jun 24, 2020
1128a44
Don't do anything at all on close if the dropdown is already closed.
rooby Jun 24, 2020
f977624
Stop the onDropDownClose event from firing when the dropdown is alrea…
rooby Jun 24, 2020
a00da6c
Revert unwanted quote change
rooby Jun 24, 2020
2a4188d
Don't do anything at all on close if the dropdown is already closed.
rooby Jun 24, 2020
6213ce6
Merge branch 'dropdown-close-event-fix' of github.com:rooby/ng-multis…
rooby Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/ng-multiselect-dropdown/src/multiselect.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,15 @@ export class MultiSelectComponent implements ControlValueAccessor {
}

closeDropdown() {
this._settings.defaultOpen = false;
// clear search text
if (this._settings.clearSearchFilter) {
this.filter.text = "";
// If the dropdown isn't open, don't do anything.
if (this._settings.defaultOpen) {
this._settings.defaultOpen = false;
// clear search text.
if (this._settings.clearSearchFilter) {
this.filter.text = "";
}
this.onDropDownClose.emit();
}
this.onDropDownClose.emit();
}

toggleSelectAll() {
Expand Down