-
Notifications
You must be signed in to change notification settings - Fork 10
chore: major nilAI refactor #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d639b2f to
a47a535
Compare
3e6776d to
309acb2
Compare
309acb2 to
a7c9a35
Compare
a7c9a35 to
a9e60ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates authentication code by removing the standalone nilai-auth project and nuc-helpers package, moving the nuc-helpers functionality into nilai_api/auth/nuc_helpers directory. The change also removes JWT authentication support while retaining NUC (Nillion User Compute) token authentication.
- Removed entire
nilai-authdirectory containing auth server, client, and helpers - Moved
nuc-helperscode tonilai_api/auth/nuc_helpers - Updated all import statements to reference the new location
Reviewed Changes
Copilot reviewed 26 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/nuc_helpers/test_usage.py | Updated imports to use new nilai_api.auth.nuc_helpers.usage path |
| tests/unit/nuc_helpers/test_nildb_document.py | Updated import for PromptDocument to new location |
| tests/unit/nilai_api/auth/test_strategies.py | Removed JWT strategy tests and updated imports |
| tests/unit/nilai_api/auth/test_jwt.py | Deleted entire JWT test file |
| tests/e2e/nuc.py | Updated imports to use new nuc_helpers location |
| pyproject.toml | Removed nuc-helpers dependency and nilai-auth workspace members |
| nilai-auth/* | Removed entire nilai-auth directory and all subprojects |
| nilai-api/src/nilai_api/auth/strategies.py | Removed JWT strategy implementation |
| nilai-api/src/nilai_api/auth/nuc_helpers/* | Updated internal imports to reference new module structure |
| nilai-api/src/nilai_api/auth/jwt.py | Deleted JWT authentication implementation |
| nilai-api/src/nilai_api/auth/common.py | Updated imports for nuc_helpers types |
| nilai-api/src/nilai_api/auth/init.py | Updated import for UsageLimitError |
| nilai-api/pyproject.toml | Removed nuc-helpers dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a9e60ab to
b89c8e5
Compare
ad75ef0 to
c206efa
Compare
b89c8e5 to
881e6ab
Compare
* feat: added improved database structure and logging * feat: updated nilauth-credit image hash * feat: unit test corrections * fix: pytests unit and e2e errors * fix: improved and fixed gpt oss CI docker compose file * fix: e2e fixes for responses endpoints * fix: nildb commands
…o_tests chore: add native client to tests
chore: remove etcd in favor of redis
…eless_containers chore: refactor remove unused containers
No description provided.