feat/replace nilchain payments with erc 20 payments #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Payment flow has fundamentally changed. The old `pay_subscription()` method is removed in favor of a decoupled flow. Replaces nilchain-based payments with Ethereum ERC-20 token burns, matching the nilauth-client-ts implementation. New payment flow: 1. `create_payment_resource()` - returns digest for BurnWithDigest contract 2. User sends on-chain tx with digest to BurnWithDigest contract 3. `validate_payment()` - validates tx hash with nilauth service API changes: - Client construction now async: `new(url)` → `create(url, chain_id).await` - `subscription_cost()` returns `u64` instead of `TokenAmount` - Added `public_key()`, `did()`, `chain_id()` getters to trait - Payload includes `chain_id` for cross-chain verification - Uses RFC 8785 canonical JSON (serde_jcs) for consistent hashing Removed: - nilchain-client dependency - pay_subscription() method - PaySubscriptionError - NillionChainClient re-export Added: - PaymentResource struct (digest + payload) - create_payment_resource() method - validate_payment() method - ValidatePaymentError, PaymentResourceError Migration: ```rs // Before (v1.x) let client = DefaultNilauthClient::new(url)?; client.pay_subscription(&mut nilchain, module, signer, did).await?; // After (v2.x) let client = DefaultNilauthClient::create(url, chain_id).await?; let resource = client.create_payment_resource(module, payer_did, subscriber_did); // ... send resource.digest to BurnWithDigest on Ethereum ... client.validate_payment(tx_hash, &resource.payload, signer).await?; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.