Address migration error and continue monorepo refactor #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all API DTOs, shared types, and constants from the nildb package into a dedicated `@nillion/nildb-types` package. This improves code reuse across the monorepo and establishes a clean boundary between API contracts and business logic.
Create a `@nillion/shared` workspace package to house common utilities. Initially, moved three core utilities from `packages/nildb/src/common/`: - `cache.ts`: Generic TTL-based cache using Temporal API - `date.ts`: Date manipulation utilities - `did-utils.ts`: DID normalization for legacy identifier format support
Given the upgrade path for moving to migrate-mongo requires either a fresh node or a node upgrading from 1.1.2, the did-migration test is no longer applicable.
- Drop redundant `nildb-` prefix in folder names: - `packages/nildb` → `packages/api` - `packages/nildb-client` → `packages/client` - `packages/nildb-types` → `packages/types` - Package names remain unchanged (@nillion/nildb, @nillion/nildb-client, etc.) - Consolidate duplicate HttpClient type exports - Extract shared HttpClient type to `packages/client/src/types.ts` - Update all client files to import from shared types - Update all internal references: - TypeScript path mappings in tsconfig files - Project references in root tsconfig.json - Docker build paths in justfile - Test fixture environment paths
tim-hm
force-pushed
the
fix/migration-conolisdation-error
branch
from
f7ed2b4 to
afe132f
Compare
tim-hm
force-pushed
the
fix/migration-conolisdation-error
branch
from
afe132f to
871aa98
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
tim-hm
force-pushed
the
fix/migration-conolisdation-error
branch
from
55e732c to
0c69d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.