ci: add automated npm publish workflow for CLI#24
Merged
Conversation
Mirrors the existing sdk-typescript-publish workflow. Triggers on cli-v* tags, verifies tag matches package.json version, runs full lint/typecheck/test, then publishes to npm with OIDC provenance.
shwetank-dev
approved these changes
Feb 26, 2026
Contributor
shwetank-dev
left a comment
There was a problem hiding this comment.
Clean implementation. Correctly mirrors sdk-typescript-publish.yml with the right structure: tag trigger → verify → OIDC-provenance publish.
Two nitpicks, both pre-existing patterns in the codebase (same in the SDK workflow):
- Node version mismatch:
verifyruns on Node 22,publishbuilds on Node 24 — the artifact shipped to npm was never directly tested on the version it was built with. - Rebuild without artifact sharing:
publishrebuilds from scratch rather than consuming the verified artifact fromverify. Negligible practical risk withtsup, but technically you're shipping a fresh build rather than the one that passed CI.
Neither is blocking. Both could be addressed in a follow-up cleanup of the SDK workflow too.
Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@nimblebrain/mpak(CLI) to npm oncli-v*tagssdk-typescript-publish.ymlpattern: verify job (lint, typecheck, test) → publish job (OIDC provenance)@nimblebrain/mpak...) to include schemas and SDKRelease workflow
Test plan
cli-v*tagsnpmenvironment exists in repo settings (already used by SDK workflow)