Use CCID when needed to connect to the nitrokey 3 #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach taken is to instead of re-opening the connection for every command, we hold an exclusive CCID connection for the entire application, and never re-open it. We can't use the same strategy as CTAHID because: When using an exclusive connection, re-opening one fails. When using a non-exclusive connection, security status changes such as pin validation will fail because operations over a key will not be using the same transaction.
sosthene-nitrokey
force-pushed
the
ccid
branch
3 times, most recently
from
d03f6e2 to
6172942
Compare
sosthene-nitrokey
requested review from
daringer,
mmerklinger and
robin-nitrokey
and removed request for
daringer
sosthene-nitrokey
force-pushed
the
ccid
branch
from
6172942 to
4892e11
Compare
nitrokeyapp/device_data.py
Outdated
| self.inner = inner | ||
|
|
||
| def __getattribute__(self, name: str) -> Any: | ||
| getattr(self.inner, name) |
Member
|
Note that this conflicts with #387 though it should not be too hard to resolve the conflicts. |
sosthene-nitrokey
force-pushed
the
ccid
branch
from
4892e11 to
30d16d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach taken is to instead of re-opening the connection for every command, we hold an exclusive CCID connection for the entire application, and never re-open it.
We can't use the same strategy as CTAHID because