Add init status EFS_FLASH_NEED_REFORMAT #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
init-status-efs-need-reformat
branch
from
c9136c9 to
13d52f8
Compare
sosthene-nitrokey
force-pushed
the
init-status-efs-need-reformat
branch
from
13d52f8 to
4206bee
Compare
sosthene-nitrokey
force-pushed
the
init-status-efs-need-reformat
branch
from
ac47ca6 to
3e4e7a9
Compare
|
I thought it was a non-breaking change but it is. Is there anything else we want to include? |
robin-nitrokey
approved these changes
May 12, 2025
CHANGELOG.md
Outdated
| @@ -6,6 +6,11 @@ | |||
|
|
|||
| [All Changes](https://github.com/Nitrokey/nitrokey-sdk-py/compare/v0.3.1...HEAD) | |||
|
|
|||
| ## [v0.4.0](https://github.com/Nitrokey/nitrokey-sdk-py/releases/tag/v0.3.2) (2025-05-12) | |||
|
|
|||
| - `nitrokey.trussed.admin_app.InitStatus`: add support for returning | |||
There was a problem hiding this comment.
Suggested change
| - `nitrokey.trussed.admin_app.InitStatus`: add support for returning | |
| - `nitrokey.trussed.admin_app.InitStatus`: add `EXT_FLASH_NEED_REFORMAT` variant |
Adding a return value to the update function is a breaking change
sosthene-nitrokey
force-pushed
the
init-status-efs-need-reformat
branch
from
3e4e7a9 to
48f1826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in Nitrokey/nitrokey-3-firmware#621