Add experimental type checks with ty #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
ty
branch
2 times, most recently
from
79c8ceb to
aac7804
Compare
This patch prepares the repository for type checks with ty and adds an experimental CI job that runs the checks. ty detected these problems in the current code: - TrussedBootloaderNrf52.update renamed an argument while overriding TrussedBootloader.update - Some ConfigFieldType functions did not handle unexpected variants. Ideally, we would use typing.assert_never here, but this has only been added in Python 3.11. - logger.warn is deprecated in favor of logger.warning. We still have to ignore these false-positives: - @functools.total_ordering is not handled correctly, see astral-sh/ty#1202 - Some imports from fake-winreg are not handled correctly, but this could also be a problem with fake-winreg.
daringer
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prepares the repository for type checks with ty and adds an experimental CI job that runs the checks.
ty detected these problems in the current code:
We still have to ignore these false-positives:
functools.total_orderingastral-sh/ty#1202