treewide: split: update split calls to make perlcritic happy #1556
+27
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
treewide: ... |
In nixpkgs this started to fail the build due to an update of, I'm guessing, perlcritic
Mindavi
force-pushed
the
bugfix/perlcritic-fixes
branch
from
eb83f24 to
306335a
Compare
Contributor
Author
|
Hmm, this actually fails the tests so something breaks with this. I wonder if the |
Mindavi
changed the title
Member
|
split is not the scope, but the function application which is changed. the scope is treewide, so
|
Contributor
Author
|
Issue seems related to this rule, but I don't really understand why it started failing now. We could also consider disabling the rule, but I think I prefer fixing the lints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nixpkgs this started to fail the build due to an update of, I'm guessing, perlcritic.
Note that hydra currently doesn't build in nixpkgs due to other issues with libpqxx, but while working on that I ran into this. See ticket NixOS/nixpkgs#476278 for background on that.