Regression test for recent fixed output derivation bug#1660
Merged
Ericson2314 merged 1 commit intomasterfrom Apr 13, 2026
Merged
Regression test for recent fixed output derivation bug#1660Ericson2314 merged 1 commit intomasterfrom
Ericson2314 merged 1 commit intomasterfrom
Conversation
Ericson2314
force-pushed
the
regression-test-for-fods
branch
from
b487f16 to
dadc7aa
Compare
Ericson2314
force-pushed
the
regression-test-for-fods
branch
from
dadc7aa to
61b27ed
Compare
Ericson2314
force-pushed
the
regression-test-for-fods
branch
2 times, most recently
from
86cd5a0 to
0f18428
Compare
It turns out that the hydra test suite was not testing fixed output derivations at all! Add a FOD test job (`fod.nix`) and end-to-end test (`queue-runner/fixed-output-derivation.t`) that: 1. Builds a flat-hash FOD through Hydra, verifying success. 2. Builds the same FOD again, verifying the queue runner detects it as cached (`isCachedBuild`). Also add a runtime check in the queue runner's `succeed_step`: for outputs with statically-known paths (input-addressed and fixed CA), verify that the paths reported by the builder match what `output_paths()` computes. A mismatch is a hard error — this would have caught the harmonia-store-core bug (missing trailing colon in the FOD fingerprint) on the very first build. I tested that this test fails before the fix, and succeeds after. Also, delete a generated file that was accidentally committed by mistake in 9911f01.
Ericson2314
force-pushed
the
regression-test-for-fods
branch
from
0f18428 to
de0abe8
Compare
Mic92
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the hydra test suite was not testing fixed output derivations at all!
See the commit message for more details