crates/db: Use harmonia types for store paths#1670
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Apr 14, 2026
Merged
Conversation
We should use nice types for all core logic. It is easiest to do so when only converting to raw types at i/o boundaries. This requires passing a `StoreDir` to database functions, although in the future the DB could store only the hash/name and not the store directory. Co-Authored-By: John Ericson <John.Ericson@Obsidian.Systems>
Ericson2314
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should use nice types for all core logic. It is easiest to do so when only converting to raw types at i/o boundaries.
This requires passing a
StoreDirto database functions, although in the future the DB could store only the hash/name and not the store directory.this was originally part of #1629, but this is not closely related to the rest of the code and is best done separately.