Skip to content

nixos.org.js : add an alias for an election-related service#862

Merged
Mic92 merged 1 commit intoNixOS:mainfrom
7c6f434c:patch-1
Oct 5, 2025
Merged

nixos.org.js : add an alias for an election-related service#862
Mic92 merged 1 commit intoNixOS:mainfrom
7c6f434c:patch-1

Conversation

@7c6f434c
Copy link
Copy Markdown
Member

@7c6f434c 7c6f434c commented Oct 4, 2025

We want to send clickable confirmation links with static target and list of clicked links in the server logs, so probably an alias to a personal VPS of an SC member should be the simplest

@7c6f434c 7c6f434c requested a review from a team as a code owner October 4, 2025 11:45
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Oct 5, 2025

I fail to immediately see why the CI jobs are failing, but I'd rather end michaelraskin.top with a dot, so that it's clear that the name is not relative to the nixos.org. zone.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Oct 5, 2025

Yes, I do believe that missing the dot is wrong. (by looking at other CNAMEs in this .js – as I'm used to zone files, not this wrapper format)

vcunat
vcunat previously requested changes Oct 5, 2025
Comment thread dns/nixos.org.js Outdated
@7c6f434c
Copy link
Copy Markdown
Member Author

7c6f434c commented Oct 5, 2025

Thanks. «I will just quickly edit this JS in the web editor, without making a local clone and also comparing to a usual zone file» was a mistake on my part, sorry

@Mic92 Mic92 enabled auto-merge October 5, 2025 08:48
We want to send clickable confirmation links with static target and list of clicked links in the server logs, so probably an alias to a personal VPS of an SC member should be the simplest
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Oct 5, 2025

Squashed the commits. I seems that auto-merge will happen after CI passes.

@Mic92 Mic92 added this pull request to the merge queue Oct 5, 2025
Merged via the queue into NixOS:main with commit aeb3d83 Oct 5, 2025
15 checks passed
@7c6f434c
Copy link
Copy Markdown
Member Author

7c6f434c commented Oct 5, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants