tests: skip test_fod_with_uncached_input_issue413 on macOS - #420
Open
edolstra wants to merge 1 commit into
Open
Conversation
This test performs a real nested `nix build`. On macOS, Nix configures a sandbox-exec profile even with sandbox=false, which cannot be nested inside the functional-tests build sandbox, failing with "sandbox initialization failed: Operation not permitted". Skip it on Darwin. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mic92
reviewed
Jun 10, 2026
|
|
||
| @pytest.mark.skipif(shutil.which("nix") is None, reason="requires nix CLI") | ||
| @pytest.mark.skipif( | ||
| sys.platform == "darwin", |
Member
There was a problem hiding this comment.
TODO: test if we can check if we run inside macOS with sandbox enabled or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a
nix flake checkfailure on macOS, as seen here: https://github.com/DeterminateSystems/nix-eval-jobs/actions/runs/27219083796/job/80530442558Running
sandbox-execinside a sandboxed build does not currently work, so just skip that test.I guess the underlying problem is that Nix always uses
sandbox-execeven when sandboxing is disabled. We should probably add a way to really disable sandboxing.