perf: only evaluate one system#1010
Closed
fricklerhandwerk wants to merge 2 commits intoNixOS:mainfrom
Closed
Conversation
fricklerhandwerk
force-pushed
the
only-eval-linux
branch
from
b525e03 to
013d8b8
Compare
This may lose some coverage, as it won't catch packages that only exist on the other platforms. But it reduces evaluation time and storage consumption to 1/4.
fricklerhandwerk
force-pushed
the
only-eval-linux
branch
from
013d8b8 to
a440542
Compare
Member
Seems like a fair trade. We might lose a bit of coverage on specific Darwin software but I suppose that's reasonable. The only thing I have in mind is |
fricklerhandwerk
force-pushed
the
only-eval-linux
branch
2 times, most recently
from
cbb10b7 to
a440542
Compare
Collaborator
Author
|
Darwin-only packages from published issues in production:
So we can't meaningfully not evaluate for Darwin... And looking at all packages, there's no strict superset of all the platforms. They have non-overlapping portions at least in the hundreds. I guess the only way for now is to deduplicate the derivation metadata by a lot to save the space, and make evaluation results asynchronously available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may lose some coverage, as it won't catch packages that only exist on the other platforms.
But it reduces evaluation time and storage consuption to 1/4.
@NixOS/security would that constitute a notable negative impact for your purposes?