feat: Email notifications#1017
Open
florentc wants to merge 1 commit intoNixOS:mainfrom
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+14
to
+16
| # def expire_cached_suggestions(old: CVEDerivationClusterProposal, new: CVEDerivationClusterProposal) -> None: | ||
| # if new.status != CVEDerivationClusterProposal.Status.PENDING: | ||
| # CachedSuggestions.objects.filter(pk=new.pk).delete() |
florentc
force-pushed
the
feat-170-email-notification
branch
from
0099535 to
a97efc9
Compare
- control panel in subscriptions page to opt in and select mail address - simplification of pgpubsub channels (now notification in sequence with caching) - emails mention affected packages, matching packages, and useful links - 1-1 correspondance between email and notification
florentc
force-pushed
the
feat-170-email-notification
branch
from
a97efc9 to
54fca42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the above screenshot my user has no github email attached, when you have one, it says "Use default GitHub email" instead of "Clear email"
2 notes:
create_package_subscription_notificationswe could optimize by using cached info instead of performing redundant db queries