Skip to content

Commit

Permalink
Merge pull request #12277 from DeterminateSystems/warn-relative-git
Browse files Browse the repository at this point in the history
Warn against the use of relative 'git+file:' flake inputs
  • Loading branch information
edolstra authored Jan 17, 2025
2 parents 12aff40 + 3197c19 commit 43a170a
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/libfetchers/git.cc
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,17 @@ struct GitInputScheme : InputScheme
//
// See: https://discourse.nixos.org/t/57783 and #9708
//
repoInfo.url = repoInfo.isLocal ? std::filesystem::absolute(url.path).string() : url.to_string();
if (repoInfo.isLocal) {
if (!isAbsolute(url.path)) {
warn(
"Fetching Git repository '%s', which uses a path relative to the current directory. "
"This is not supported and will stop working in a future release. "
"See https://github.com/NixOS/nix/issues/12281 for details.",
url);
}
repoInfo.url = std::filesystem::absolute(url.path).string();
} else
repoInfo.url = url.to_string();

// If this is a local directory and no ref or revision is
// given, then allow the use of an unclean working tree.
Expand Down

0 comments on commit 43a170a

Please sign in to comment.