-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up packaging a bit #11799
Clean up packaging a bit #11799
Conversation
f2cc4a6
to
f29e37e
Compare
43b5e29
to
47fc38c
Compare
47fc38c
to
d7765db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright. Seems to be an improvement.
Did you test all the attributes?
d7765db
to
d574e02
Compare
@Mergifyio rebase |
❌ Unable to rebase: user
|
- Multiple choices of stdenv are handled more consistently, especially for the dev shells which were previously not done correctly. - Some stray nix code was moving into the `packaging` directory
d574e02
to
69fde53
Compare
OK now that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright. Will give Hydra a kick so that we can confirm.
Oh, I don't have permission to start nix:master evals anymore? |
doc/building: Update for #11799
Reflect the shorter attribute name, changed in f168a6e NixOS#11799
Motivation
Multiple choices of stdenv are handled more consistently, especially for the dev shells which were previously not done correctly.
Some stray nix code was moving into the
packaging
directoryContext
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.