WIP: Add scoped expressions inspired by OCaml #12471
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parsing works but it has the semantics of normal `with` currently. I am currently calling it `scoped dot`, because calling it `innermost with` would maybe make people confuse them with the current `outermost with` expressions
github-actions
bot
added
the
with-tests
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/alternatives-to-with-expression/60272/1 |
|
Oh wait there's https://github.com/r-burns/nixos-rfcs/blob/rfc-inherit-as-list/rfcs/0110-inherit-as-list.md that I need to read over the weekend |
roberth
reviewed
Feb 15, 2025
| enum class Binding { | ||
| /** Classic `with` behaviour */ | ||
| Outermost, | ||
| /** `with` behaviour mimicking OCaml's `foo.( <expr> )` */ |
There was a problem hiding this comment.
mimicking
In what ways does it fall short?
| @@ -0,0 +1 @@ | |||
| "x: (as-a as-b) y: (bs-a bs-b)" | |||
There was a problem hiding this comment.
Suggested change
| "x: (as-a as-b) y: (bs-a bs-b)" | |
| "x is (as-a as-b) and y is (bs-a bs-b)" |
Confused me for a sec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: The parsing works but it has the semantics of normal
withcurrently.I am currently calling it
scoped dot, because calling itinnermost withwould maybe make people confuse them with the currentoutermost withexpressionsAlso put up a discussion at https://discourse.nixos.org/t/alternatives-to-with-expression/60272
This solution took inspiration from OCaml: "module access notation" in https://ocaml.org/docs/modules and "local open" in https://ocaml.org/manual/5.3/moduleexamples.html.
Motivation
With expressions are convenient, but confusing (i.e. taking the outermost binding), but the alternative of using
builtins.attrValues { inherit (foo) a b c; }instead ofwith foo; [a b c]is cumbersome.This is taking inspiration from OCaml.
Context
Changing the parser is always something to be done with care. I should definitely add more tests, and people should try it out before it gets merged with something suboptimal.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.