mirror-nixos-branch: fix git fatal: bad object error
#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I wrote 30efa0a, I had the assumption that the GIT_DIR in /home/hydra-mirror/nixpkgs-channels is always up-to-date, but it isn't. The actual local GIT_DIR only gets updated far further down (line 346). This commit fixes the issue of git not yet knowing the $rev by fetching only that $rev early, instead of moving the much more expensive git remote update that would update all branches of nixpkgs, all the time.
mweinelt
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I wrote #99 (30efa0a), I had the assumption that the
GIT_DIRin/home/hydra-mirror/nixpkgs-channelsis always up-to-date, but it isn't.The actual local
GIT_DIRonly gets updated far further down (line 346).This commit fixes the issue of
gitnot yet knowing the$revby fetching only that$revearly, instead of moving the much more expensivegit remote updatethat would update all branches of nixpkgs, all the time.