raspberry-pi-4: add gpio-fan overlay#1826
Conversation
069f82d to
2b80dc8
Compare
Adds support for some PWM GPIO fans in a similar way to the official `gpio-fan` overlay. Tested with Argon Mini Fan.
2b80dc8 to
0db5d00
Compare
|
@JamieMagee do you think you could test this PR? |
I don't own this exact fan, but comparing with the upstream
I assume both of these are due to the fixed pins on this fan only working with the exact layout of the Raspberry Pi 4, and forcing pin 18. In that regard, this looks correct. I think I'd like to try and land a generic But I don't know how long that would take, so I'm not opposed to this PR. I'd maybe just make it clearer that the defaults are for the Argon case fan, and not something like the official Raspberry Pi 4 fan |
|
|
||
| pin = lib.mkOption { | ||
| type = lib.types.int; | ||
| default = 18; |
There was a problem hiding this comment.
@matiasyocca Maybe it'd be more correct to specify 12? Or 14 maybe? Here's what I saw here:
| { | ||
| options.hardware = { | ||
| raspberry-pi."4".gpio-fan = { | ||
| enable = lib.mkEnableOption "support for Raspberry Pi style gpio-fan control"; |
There was a problem hiding this comment.
Maybe:
| enable = lib.mkEnableOption "support for Raspberry Pi style gpio-fan control"; | |
| enable = lib.mkEnableOption "support for [Raspberry Pi gpio-fan](https://www.raspberrypi.com/products/raspberry-pi-4-case-fan/) control"; |
Description of changes
Adds support for some PWM GPIO fans in a similar way to the official
gpio-fanoverlay. Tested with Argon Mini Fan.Here's the instruction manual for the fan for reference: https://malnapc.hu/custom/malnapc/image/data/docs/RS/A700000007741984.pdf
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input