raspberry-pi: replace deprecated lib.overrideDerivation with .overrideAttrs#1839
Open
JamieMagee wants to merge 1 commit intoNixOS:masterfrom
Open
raspberry-pi: replace deprecated lib.overrideDerivation with .overrideAttrs#1839JamieMagee wants to merge 1 commit intoNixOS:masterfrom
JamieMagee wants to merge 1 commit intoNixOS:masterfrom
Conversation
lib.overrideDerivation is deprecated and strips passthru attributes (.configfile, .moduleBuildDependencies, etc.) from the kernel derivation, which breaks downstream users expecting a standard buildLinux output. .overrideAttrs preserves passthru and matches every other custom kernel in this repo.
JamieMagee
force-pushed
the
raspberry-pi/replace-overrideDerivation
branch
from
d743ab3 to
d751433
Compare
Member
Author
|
@concatime @fkokosinski @Cryolitia I know you're active in contributing and reviewing Raspberry Pi changes. If you have time, could you review this, and the other Raspberry Pi changes I have please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
lib.overrideDerivationis deprecated and strips passthru attributes (.configfile,.moduleBuildDependencies, etc.) from the kernel derivation, breaking downstream customization. This was the only usage in the repo..overrideAttrspreserves passthru.postConfigureandpostFixupbodies are unchanged.Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input