Skip to content

Conversation

@mschwaig
Copy link
Member

No description provided.

Copy link
Contributor

@crertel crertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see comment. We may already have some of this for you.

@mschwaig mschwaig force-pushed the add-prettier-to-dev-shell branch from c8124ff to 5de868e Compare November 21, 2024 14:54
@mschwaig
Copy link
Member Author

Actually if npm manages what version of prettier is used, then adding the one from nixpkgs to the command line might not be a good idea, so I removed that from this PR again.

I got the idea from the log of the failing format check here: https://github.com/NixOS/nixos-homepage/actions/runs/11843965454/job/33006101651

@mschwaig mschwaig requested a review from crertel November 21, 2024 14:56
@thilobillerbeck thilobillerbeck merged commit af1e5b8 into NixOS:main Nov 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants