Skip to content

Conversation

@jopejoe1
Copy link
Member

Currently the logo is a draft as we wait for the finished version!

@jopejoe1 jopejoe1 requested a review from a team November 30, 2025 17:01
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@jopejoe1 jopejoe1 marked this pull request as ready for review November 30, 2025 17:56
@jopejoe1 jopejoe1 merged commit 9b7d282 into main Nov 30, 2025
5 checks passed
@jopejoe1 jopejoe1 deleted the 25.11-release branch November 30, 2025 17:56
@thilobillerbeck
Copy link
Collaborator

I'd kindly ask you to at least wait for one of the marketing team mebers to review a PR

@wolfgangwalther
Copy link
Contributor

What does the marketing team have to do with the release? I don't get it.

@thilobillerbeck
Copy link
Collaborator

thilobillerbeck commented Nov 30, 2025

Nothing, but we maintain this repo and especially if something breaks, we are the ones who will be addressed. This is why we usually want to review PRs by ourselves as well.

@wolfgangwalther
Copy link
Contributor

OK, but if the expectation is that a marketing team member reviews this kind of PR - then the release team doesn't need write permissions at all, right? Because the marketing team could then merge it as well.

So why does the release team have write permissions? Is it not exactly because of publishing the release announcement in a timely manner?

Either they have these privileges for something else and were overstepping, or they have these privileges for exactly this scenario and your request is invalid.

@mweinelt
Copy link
Member

mweinelt commented Nov 30, 2025

Availability of marketing did vary over the years, so I think that is why release team got write access eventually.

@thilobillerbeck
Copy link
Collaborator

thilobillerbeck commented Nov 30, 2025

OK, but if the expectation is that a marketing team member reviews this kind of PR - then the release team doesn't need write permissions at all, right? Because the marketing team could then merge it as well.

what @mweinelt says. If something goes terribly wrong in terms of lack of administration, then people can act (especially since we are pretty small).

So why does the release team have write permissions? Is it not exactly because of publishing the release announcement in a timely manner?

In a perfect world we would have had some time before the release to review. I guess noone knew that I kept track of Github the whole day and I also heard there was kind of a hurry this time. So I guess there was some messed up communication.

Either they have these privileges for something else and were overstepping, or they have these privileges for exactly this scenario and your request is invalid.

I don't want to have a pretty high bus factor in this repository, but a one hour time frame does not leave any breathing room for reaction, though as stated above, I kind of get why this needed to happen.

Sorry if I my initial comment sounded a bit harsh.

@leona-ya
Copy link
Member

leona-ya commented Nov 30, 2025

In this case, I planned to do a draft PR a few days back for the marketing team to review it. Due to unexpected, acute personal problems I didn't have time and capacity for that, I'm sorry.

Also, for the same reasons I have not the mind capacity to make this better for that I'm also sorry. (and btw I'm also relatively unavailable for the project in the next days)

@thilobillerbeck
Copy link
Collaborator

In this case, I planned to do a draft PR a few days back for the marketing team to review it. Due to unexpected, acute personal problems I didn't have time and capacity for that, I'm sorry.

Absolutely understandable. I hope your problem got resolved. Take care. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants