Skip to content

feat(flakes): github:in-a-dil-emma/declarative-flatpak#1015

Merged
raboof merged 2 commits intoNixOS:mainfrom
Malix-Labs:patch-1
Feb 18, 2026
Merged

feat(flakes): github:in-a-dil-emma/declarative-flatpak#1015
raboof merged 2 commits intoNixOS:mainfrom
Malix-Labs:patch-1

Conversation

@Malix-Labs
Copy link
Copy Markdown
Contributor

@Malix-Labs Malix-Labs commented Sep 23, 2025

@Malix-Labs Malix-Labs changed the title feat: flake github:in-a-dil-emma/declarative-flatpak feat(flakes): github:in-a-dil-emma/declarative-flatpak Sep 29, 2025
Copilot AI review requested due to automatic review settings January 2, 2026 12:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@miniBill miniBill added the flake PRs that add/update flakes label Feb 11, 2026
@raboof
Copy link
Copy Markdown
Member

raboof commented Feb 12, 2026

error seems to be #902

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented Feb 14, 2026

#1015 (comment) from @raboof :

error seems to be #902

The error from this PR only github:in-a-dil-emma/declarative-flatpak is coming from a bug in flake-info about literalMD parsing

I fixed it in #1142 (and cherry picked it in 742e4fd)

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented Feb 14, 2026

Indeed, github:in-a-dil-emma/declarative-flatpak correctly works now!


The problem is that this PR is failing for extraneous reasons;
Because the CI flake checks is incorrectly implemented (see #1027 and #1144)

The reason this PR is failing is because of #1027 and #1144;
The reason the other flakes are failing is beacause of #1143

So we have 3 options:

  1. Hold PRs that are introducing valid flakes until fix(ci): Flakes Check - Decoupling Patches and Batch #1027 and fix(flakes): pinning locking #1144 is fixed
  2. Merge PRs that are introducing valid flakes even though fix(ci): Flakes Check - Decoupling Patches and Batch #1027 and fix(flakes): pinning locking #1144 is not fixed
  3. Make extraneous changes (such as feat(flake-info): fallbacks #1143) to PRs introducing valid flakes to comply with the incorrectly implemented CI (see fix(ci): Flakes Check - Decoupling Patches and Batch #1027 and fix(flakes): pinning locking #1144)

I think option 1 is the most valid, 2 is if we are in a rush (which we are not) and option 3 is plainly incorrect

@Malix-Labs Malix-Labs marked this pull request as ready for review February 14, 2026 19:13
@Malix-Labs Malix-Labs force-pushed the patch-1 branch 2 times, most recently from da297e5 to 742e4fd Compare February 14, 2026 19:22
@raboof
Copy link
Copy Markdown
Member

raboof commented Feb 15, 2026

Indeed, github:in-a-dil-emma/declarative-flatpak correctly works now!

The problem is that this PR is failing for extraneous reasons; Because the CI flake checks is incorrectly implemented (see #1027 and #1144)

The reason this PR is failing is because of #1027 and #1144; The reason the other flakes are failing is beacause of #1143

You do have access to the PR failure logs, right? The PR is still failing on github:in-a-dil-emma/declarative-flatpak:

2026-02-14T19:38:34.6656834Z [2026-02-14T19:38:34Z INFO  command_run] nix flake metadata --json --no-write-lock-file github:in-a-dil-emma/declarative-flatpak
2026-02-14T19:38:35.1672746Z [2026-02-14T19:38:35Z INFO  command_run] nix eval --json --no-allow-import-from-derivation --no-write-lock-file -f '/nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixpkgs-unstable.tar.gz --override-flake input-flake github:in-a-dil-emma/declarative-flatpak --argstr flake github:in-a-dil-emma/declarative-flatpak all
2026-02-14T19:38:40.8715428Z [2026-02-14T19:38:40Z ERROR command_run] command 'nix eval --json --no-allow-import-from-derivation --no-write-lock-file -f '/nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixpkgs-unstable.tar.gz --override-flake input-flake github:in-a-dil-emma/declarative-flatpak --argstr flake github:in-a-dil-emma/declarative-flatpak all' failed: exit status: 1
2026-02-14T19:38:40.8718601Z     stdout:
2026-02-14T19:38:40.8718866Z     
2026-02-14T19:38:40.8719066Z     stderr:
2026-02-14T19:38:40.8719219Z     error:
2026-02-14T19:38:40.8719620Z            … while evaluating a branch condition
2026-02-14T19:38:40.8720113Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:221:5:
2026-02-14T19:38:40.8720578Z               220|     # are multiple modules
2026-02-14T19:38:40.8720950Z               221|     if nixosModulesOpts != [ ] then nixosModulesOpts else nixosModuleOpts;
2026-02-14T19:38:40.8721313Z                  |     ^
2026-02-14T19:38:40.8721751Z               222|
2026-02-14T19:38:40.8721921Z     
2026-02-14T19:38:40.8722302Z            … while calling the 'concatLists' builtin
2026-02-14T19:38:40.8722775Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:201:26:
2026-02-14T19:38:40.8723217Z               200|     let
2026-02-14T19:38:40.8723468Z               201|       nixosModulesOpts = builtins.concatLists (
2026-02-14T19:38:40.8723749Z                  |                          ^
2026-02-14T19:38:40.8723993Z               202|         lib.mapAttrsToList (
2026-02-14T19:38:40.8724220Z     
2026-02-14T19:38:40.8724429Z            … while calling anonymous lambda
2026-02-14T19:38:40.8724873Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:203:23:
2026-02-14T19:38:40.8725678Z               202|         lib.mapAttrsToList (
2026-02-14T19:38:40.8725939Z               203|           moduleName: module:
2026-02-14T19:38:40.8726178Z                  |                       ^
2026-02-14T19:38:40.8726418Z               204|           readNixOSOptions {
2026-02-14T19:38:40.8726656Z     
2026-02-14T19:38:40.8726849Z            … from call site
2026-02-14T19:38:40.8727260Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:204:11:
2026-02-14T19:38:40.8727718Z               203|           moduleName: module:
2026-02-14T19:38:40.8733753Z               204|           readNixOSOptions {
2026-02-14T19:38:40.8734164Z                  |           ^
2026-02-14T19:38:40.8734403Z               205|             inherit module;
2026-02-14T19:38:40.8734644Z     
2026-02-14T19:38:40.8735085Z            … while calling anonymous lambda
2026-02-14T19:38:40.8735576Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:185:5:
2026-02-14T19:38:40.8736023Z               184|     in
2026-02-14T19:38:40.8736212Z               185|     {
2026-02-14T19:38:40.8736388Z                  |     ^
2026-02-14T19:38:40.8736578Z               186|       module,
2026-02-14T19:38:40.8736768Z     
2026-02-14T19:38:40.8736989Z            … while calling the 'map' builtin
2026-02-14T19:38:40.8737461Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:195:5:
2026-02-14T19:38:40.8737918Z               194|     in
2026-02-14T19:38:40.8738154Z               195|     map (cleanUpOption extraAttrs) (
2026-02-14T19:38:40.8738404Z                  |     ^
2026-02-14T19:38:40.8738769Z               196|       lib.filter (x: x.visible && !x.internal && lib.head x.loc != "_module") opts
2026-02-14T19:38:40.8739137Z     
2026-02-14T19:38:40.8739351Z            … while calling the 'filter' builtin
2026-02-14T19:38:40.8739814Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:196:7:
2026-02-14T19:38:40.8740297Z               195|     map (cleanUpOption extraAttrs) (
2026-02-14T19:38:40.8740725Z               196|       lib.filter (x: x.visible && !x.internal && lib.head x.loc != "_module") opts
2026-02-14T19:38:40.8741098Z                  |       ^
2026-02-14T19:38:40.8741275Z               197|     );
2026-02-14T19:38:40.8741451Z     
2026-02-14T19:38:40.8741628Z            … from call site
2026-02-14T19:38:40.8742039Z              at /nix/store/84jcr65r79zmrb3jz4zx54h91g38liid-flake-info/assets/commands/flake_info.nix:190:14:
2026-02-14T19:38:40.8742477Z               189|     let
2026-02-14T19:38:40.8742753Z               190|       opts = lib.optionAttrSetToDocList (declarations module);
2026-02-14T19:38:40.8743074Z                  |              ^
2026-02-14T19:38:40.8743349Z               191|       extraAttrs = lib.optionalAttrs (modulePath != null) {
2026-02-14T19:38:40.8743642Z     
2026-02-14T19:38:40.8743867Z            … while calling 'optionAttrSetToDocList''
2026-02-14T19:38:40.8744269Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/options.nix:571:8:
2026-02-14T19:38:40.8744842Z               570|   optionAttrSetToDocList' =
2026-02-14T19:38:40.8745432Z               571|     _: options:
2026-02-14T19:38:40.8745644Z                  |        ^
2026-02-14T19:38:40.8745840Z               572|     concatMap (
2026-02-14T19:38:40.8746036Z     
2026-02-14T19:38:40.8746267Z            … while calling the 'concatMap' builtin
2026-02-14T19:38:40.8746689Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/options.nix:572:5:
2026-02-14T19:38:40.8747071Z               571|     _: options:
2026-02-14T19:38:40.8747286Z               572|     concatMap (
2026-02-14T19:38:40.8747483Z                  |     ^
2026-02-14T19:38:40.8747669Z               573|       opt:
2026-02-14T19:38:40.8747858Z     
2026-02-14T19:38:40.8748041Z            … from call site
2026-02-14T19:38:40.8748381Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/options.nix:611:8:
2026-02-14T19:38:40.8748834Z               610|       [ docOption ] ++ optionals subOptionsVisible subOptions
2026-02-14T19:38:40.8749181Z               611|     ) (collect isOption options);
2026-02-14T19:38:40.8749428Z                  |        ^
2026-02-14T19:38:40.8749609Z               612|
2026-02-14T19:38:40.8749763Z     
2026-02-14T19:38:40.8749961Z            … while calling 'collect'
2026-02-14T19:38:40.8750328Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:872:11:
2026-02-14T19:38:40.8750711Z               871|   collect =
2026-02-14T19:38:40.8750914Z               872|     pred: attrs:
2026-02-14T19:38:40.8751116Z                  |           ^
2026-02-14T19:38:40.8751318Z               873|     if pred attrs then
2026-02-14T19:38:40.8751534Z     
2026-02-14T19:38:40.8751747Z            … while calling the 'concatMap' builtin
2026-02-14T19:38:40.8752147Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:876:7:
2026-02-14T19:38:40.8752548Z               875|     else if isAttrs attrs then
2026-02-14T19:38:40.8752845Z               876|       concatMap (collect pred) (attrValues attrs)
2026-02-14T19:38:40.8753129Z                  |       ^
2026-02-14T19:38:40.8753307Z               877|     else
2026-02-14T19:38:40.8753484Z     
2026-02-14T19:38:40.8753667Z            … while calling 'collect'
2026-02-14T19:38:40.8754029Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:872:11:
2026-02-14T19:38:40.8754403Z               871|   collect =
2026-02-14T19:38:40.8754600Z               872|     pred: attrs:
2026-02-14T19:38:40.8754800Z                  |           ^
2026-02-14T19:38:40.8755216Z               873|     if pred attrs then
2026-02-14T19:38:40.8755443Z     
2026-02-14T19:38:40.8755662Z            … while calling the 'concatMap' builtin
2026-02-14T19:38:40.8756058Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:876:7:
2026-02-14T19:38:40.8756458Z               875|     else if isAttrs attrs then
2026-02-14T19:38:40.8756750Z               876|       concatMap (collect pred) (attrValues attrs)
2026-02-14T19:38:40.8757022Z                  |       ^
2026-02-14T19:38:40.8757211Z               877|     else
2026-02-14T19:38:40.8757383Z     
2026-02-14T19:38:40.8757569Z            … while calling 'collect'
2026-02-14T19:38:40.8757929Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:872:11:
2026-02-14T19:38:40.8758299Z               871|   collect =
2026-02-14T19:38:40.8758496Z               872|     pred: attrs:
2026-02-14T19:38:40.8758695Z                  |           ^
2026-02-14T19:38:40.8758893Z               873|     if pred attrs then
2026-02-14T19:38:40.8759102Z     
2026-02-14T19:38:40.8759316Z            … while calling the 'concatMap' builtin
2026-02-14T19:38:40.8759694Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:876:7:
2026-02-14T19:38:40.8760083Z               875|     else if isAttrs attrs then
2026-02-14T19:38:40.8760369Z               876|       concatMap (collect pred) (attrValues attrs)
2026-02-14T19:38:40.8760769Z                  |       ^
2026-02-14T19:38:40.8761055Z               877|     else
2026-02-14T19:38:40.8761227Z     
2026-02-14T19:38:40.8761418Z            … while calling 'collect'
2026-02-14T19:38:40.8761766Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:872:11:
2026-02-14T19:38:40.8762146Z               871|   collect =
2026-02-14T19:38:40.8762335Z               872|     pred: attrs:
2026-02-14T19:38:40.8762539Z                  |           ^
2026-02-14T19:38:40.8762734Z               873|     if pred attrs then
2026-02-14T19:38:40.8762940Z     
2026-02-14T19:38:40.8763153Z            … while evaluating a branch condition
2026-02-14T19:38:40.8763528Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:873:5:
2026-02-14T19:38:40.8763900Z               872|     pred: attrs:
2026-02-14T19:38:40.8764109Z               873|     if pred attrs then
2026-02-14T19:38:40.8764327Z                  |     ^
2026-02-14T19:38:40.8764514Z               874|       [ attrs ]
2026-02-14T19:38:40.8764714Z     
2026-02-14T19:38:40.8765045Z            … from call site
2026-02-14T19:38:40.8765484Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/attrsets.nix:873:8:
2026-02-14T19:38:40.8765862Z               872|     pred: attrs:
2026-02-14T19:38:40.8766077Z               873|     if pred attrs then
2026-02-14T19:38:40.8766302Z                  |        ^
2026-02-14T19:38:40.8766481Z               874|       [ attrs ]
2026-02-14T19:38:40.8766674Z     
2026-02-14T19:38:40.8766865Z            … while calling 'isType'
2026-02-14T19:38:40.8767218Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/types.nix:140:18:
2026-02-14T19:38:40.8767585Z               139| rec {
2026-02-14T19:38:40.8767825Z               140|   isType = type: x: (x._type or "") == type;
2026-02-14T19:38:40.8768097Z                  |                  ^
2026-02-14T19:38:40.8768300Z               141|
2026-02-14T19:38:40.8768465Z     
2026-02-14T19:38:40.8768642Z            … from call site
2026-02-14T19:38:40.8768979Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/types.nix:140:22:
2026-02-14T19:38:40.8769340Z               139| rec {
2026-02-14T19:38:40.8769565Z               140|   isType = type: x: (x._type or "") == type;
2026-02-14T19:38:40.8769825Z                  |                      ^
2026-02-14T19:38:40.8770036Z               141|
2026-02-14T19:38:40.8770187Z     
2026-02-14T19:38:40.8770390Z            … while calling anonymous lambda
2026-02-14T19:38:40.8770766Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:923:37:
2026-02-14T19:38:40.8771131Z               922|
2026-02-14T19:38:40.8771420Z               923|       matchedOptions = mapAttrs (n: v: v.matchedOptions) resultsByName;
2026-02-14T19:38:40.8771786Z                  |                                     ^
2026-02-14T19:38:40.8772015Z               924|
2026-02-14T19:38:40.8772163Z     
2026-02-14T19:38:40.8772426Z            … while evaluating the attribute 'matchedOptions'
2026-02-14T19:38:40.8772867Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:889:13:
2026-02-14T19:38:40.8773243Z               888|           {
2026-02-14T19:38:40.8773514Z               889|             matchedOptions = evalOptionValue loc opt defns';
2026-02-14T19:38:40.8773817Z                  |             ^
2026-02-14T19:38:40.8774041Z               890|             unmatchedDefns = [ ];
2026-02-14T19:38:40.8774270Z     
2026-02-14T19:38:40.8774448Z            … from call site
2026-02-14T19:38:40.8774778Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:889:30:
2026-02-14T19:38:40.8775358Z               888|           {
2026-02-14T19:38:40.8775648Z               889|             matchedOptions = evalOptionValue loc opt defns';
2026-02-14T19:38:40.8775974Z                  |                              ^
2026-02-14T19:38:40.8776361Z               890|             unmatchedDefns = [ ];
2026-02-14T19:38:40.8776595Z     
2026-02-14T19:38:40.8776938Z            … while calling 'evalOptionValue'
2026-02-14T19:38:40.8777332Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:1121:15:
2026-02-14T19:38:40.8777730Z              1120|   evalOptionValue =
2026-02-14T19:38:40.8777954Z              1121|     loc: opt: defs:
2026-02-14T19:38:40.8778166Z                  |               ^
2026-02-14T19:38:40.8778374Z              1122|     let
2026-02-14T19:38:40.8778551Z     
2026-02-14T19:38:40.8778804Z            … in the left operand of the update (//) operator
2026-02-14T19:38:40.8779232Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:1159:5:
2026-02-14T19:38:40.8779635Z              1158|     warnDeprecation opt
2026-02-14T19:38:40.8779860Z              1159|     // {
2026-02-14T19:38:40.8780047Z                  |     ^
2026-02-14T19:38:40.8780409Z              1160|       value = addErrorContext "while evaluating the option `${showOption loc}':" value;
2026-02-14T19:38:40.8780810Z     
2026-02-14T19:38:40.8780988Z            … from call site
2026-02-14T19:38:40.8781322Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:1154:9:
2026-02-14T19:38:40.8781712Z              1153|       warnDeprecation =
2026-02-14T19:38:40.8782003Z              1154|         warnIf (opt.type.deprecationMessage != null)
2026-02-14T19:38:40.8782293Z                  |         ^
2026-02-14T19:38:40.8782892Z              1155|           "The type `types.${opt.type.name}' of option `${showOption loc}' defined in ${showFiles opt.declarations} is deprecated. ${opt.type.deprecationMessage}";
2026-02-14T19:38:40.8783523Z     
2026-02-14T19:38:40.8783710Z            … while calling 'warnIf'
2026-02-14T19:38:40.8784074Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/trivial.nix:852:18:
2026-02-14T19:38:40.8784447Z               851|   */
2026-02-14T19:38:40.8784695Z               852|   warnIf = cond: msg: if cond then warn msg else x: x;
2026-02-14T19:38:40.8785248Z                  |                  ^
2026-02-14T19:38:40.8785458Z               853|
2026-02-14T19:38:40.8785616Z     
2026-02-14T19:38:40.8785835Z            … while evaluating a branch condition
2026-02-14T19:38:40.8786221Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/trivial.nix:852:23:
2026-02-14T19:38:40.8786583Z               851|   */
2026-02-14T19:38:40.8786826Z               852|   warnIf = cond: msg: if cond then warn msg else x: x;
2026-02-14T19:38:40.8787121Z                  |                       ^
2026-02-14T19:38:40.8787325Z               853|
2026-02-14T19:38:40.8787480Z     
2026-02-14T19:38:40.8787654Z            … from call site
2026-02-14T19:38:40.8787989Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:886:19:
2026-02-14T19:38:40.8788354Z               885|           let
2026-02-14T19:38:40.8788652Z               886|             opt = fixupOptionType loc (mergeOptionDecls loc decls);
2026-02-14T19:38:40.8788976Z                  |                   ^
2026-02-14T19:38:40.8789189Z               887|           in
2026-02-14T19:38:40.8789376Z     
2026-02-14T19:38:40.8789581Z            … while calling 'fixupOptionType'
2026-02-14T19:38:40.8789965Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:1439:10:
2026-02-14T19:38:40.8790346Z              1438|   fixupOptionType =
2026-02-14T19:38:40.8790567Z              1439|     loc: opt:
2026-02-14T19:38:40.8790763Z                  |          ^
2026-02-14T19:38:40.8791022Z              1440|     if opt.type.getSubModules or null == null then
2026-02-14T19:38:40.8791297Z     
2026-02-14T19:38:40.8791508Z            … while evaluating a branch condition
2026-02-14T19:38:40.8791891Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:1440:5:
2026-02-14T19:38:40.8792256Z              1439|     loc: opt:
2026-02-14T19:38:40.8792654Z              1440|     if opt.type.getSubModules or null == null then
2026-02-14T19:38:40.8793036Z                  |     ^
2026-02-14T19:38:40.8793285Z              1441|       opt // { type = opt.type or types.unspecified; }
2026-02-14T19:38:40.8793560Z     
2026-02-14T19:38:40.8793821Z            … while evaluating the attribute 'type.getSubModules'
2026-02-14T19:38:40.8794233Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/types.nix:286:9:
2026-02-14T19:38:40.8794607Z               285|         getSubOptions
2026-02-14T19:38:40.8794834Z               286|         getSubModules
2026-02-14T19:38:40.8795332Z                  |         ^
2026-02-14T19:38:40.8795547Z               287|         substSubModules
2026-02-14T19:38:40.8795765Z     
2026-02-14T19:38:40.8795951Z            … from call site
2026-02-14T19:38:40.8796296Z              at /nix/store/pqlsm8x4kk711qcc4f9mwm2wxq0kplay-source/module/options.nix:27:12:
2026-02-14T19:38:40.8796751Z                26|   inherit (lib) mkOption mkEnableOption pipe;
2026-02-14T19:38:40.8797047Z                27|   inherit (pkgs) callPackage;
2026-02-14T19:38:40.8797299Z                  |            ^
2026-02-14T19:38:40.8797488Z                28|
2026-02-14T19:38:40.8797639Z     
2026-02-14T19:38:40.8797848Z            … while calling anonymous lambda
2026-02-14T19:38:40.8798231Z              at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:723:15:
2026-02-14T19:38:40.8798639Z               722|       extraArgs = mapAttrs (
2026-02-14T19:38:40.8798877Z               723|         name: _:
2026-02-14T19:38:40.8799091Z                  |               ^
2026-02-14T19:38:40.8799331Z               724|         addErrorContext (context name) (
2026-02-14T19:38:40.8799586Z     
2026-02-14T19:38:40.8800135Z            … while evaluating the module argument `pkgs' in "/nix/store/pqlsm8x4kk711qcc4f9mwm2wxq0kplay-source/module/options.nix":
2026-02-14T19:38:40.8800666Z     
2026-02-14T19:38:40.8801147Z            … noting that argument `pkgs` is not externally provided, so querying `_module.args` instead, requiring `config`
2026-02-14T19:38:40.8801606Z     
2026-02-14T19:38:40.8801769Z            error: attribute 'pkgs' missing
2026-02-14T19:38:40.8802147Z            at /nix/store/wzcf74b2g5c3qfg4rcswcz28ngiwzzp0-source/lib/modules.nix:727:13:
2026-02-14T19:38:40.8802808Z               726|             "noting that argument `${name}` is not externally provided, so querying `_module.args` instead, requiring `config`"
2026-02-14T19:38:40.8803344Z               727|             config._module.args.${name}
2026-02-14T19:38:40.8803596Z                  |             ^
2026-02-14T19:38:40.8803797Z               728|           )
2026-02-14T19:38:40.8803975Z     

... which still looks a lot like #902 to me.

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented Feb 15, 2026

Ah yes sorry, I mix matched the branches, thanks for the notice!

It fails for github:in-a-dil-emma/declarative-flatpak specifically due to both #1142 AND #1141 apparently

Let's test cherry-picking #1141 as well

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented Feb 15, 2026

Indeed @raboof, you were right!

It was caused by problems fixed by #1141 and I think also #1142 (I am like 90% sure but it seems I confused PRs numbers when I was typing so I need to check again to be sure)

I cherry picked both PRs in this one and declarative-flatpak passes now

@Malix-Labs Malix-Labs force-pushed the patch-1 branch 3 times, most recently from 569b064 to 3b4edd7 Compare February 17, 2026 22:09
@raboof raboof merged commit abbe486 into NixOS:main Feb 18, 2026
4 checks passed
@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented Feb 18, 2026

@raboof if you prefer something cleaner, you you can revert this PR, and I will rebase #1141 to clear the mess so you could merge #1141 afterwards, and then I will reabse this commit to remove the cherry pick

@raboof
Copy link
Copy Markdown
Member

raboof commented Feb 18, 2026

TBH I'm OK with having it like this! really cool result, thanks for digging into this!

@Malix-Labs Malix-Labs deleted the patch-1 branch February 18, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flake PRs that add/update flakes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants