ci(manage-es): quote URL substitution to preserve query params#1247
Open
KiaraGrouwstra wants to merge 1 commit intomainfrom
Open
ci(manage-es): quote URL substitution to preserve query params#1247KiaraGrouwstra wants to merge 1 commit intomainfrom
KiaraGrouwstra wants to merge 1 commit intomainfrom
Conversation
Without quotes, the runtime curl command read e.g. `curl -X GET https://.../foo?v&h=name,active` where bash parses the first `&` as a background operator: the curl process forks on `?v` and the rest of the URL turns into separate shell commands (`h=name,active`, `request_cache=true`), silently dropping every query parameter past the first. Looked like a multi- parameter request from the dispatch UI but came out as a one-parameter GET on the wire. Quoting both substitutions preserves `&` as part of the URL. Assisted-by: Claude:claude-opus-4-7[1m]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without quotes, the runtime curl command read e.g.
curl -X GET https://.../foo?v&h=name,activewhere bash parses the first
&as a background operator: the curl process forks on?vand the rest of the URL turns into separate shell commands (h=name,active,request_cache=true), silently dropping every query parameter past the first. Looked like a multi-parameter request from the dispatch UI but came out as a one-parameter GET on the wire.Quoting both substitutions preserves
&as part of the URL.The effect of this may be found by comparing queries to Elastic Search before vs after this change - showing that only after will the
hheader filter correctly apply.Assisted-by: Claude:claude-opus-4-7[1m]