Skip to content

cd-hit: fix darwin build#123026

Merged
veprbl merged 2 commits into
NixOS:masterfrom
stephank:fix-cd-hit-darwin
May 14, 2021
Merged

cd-hit: fix darwin build#123026
veprbl merged 2 commits into
NixOS:masterfrom
stephank:fix-cd-hit-darwin

Conversation

@stephank

Copy link
Copy Markdown
Contributor
Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142598941/log

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label May 14, 2021
@ofborg ofborg Bot requested a review from bzizou May 14, 2021 20:14
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 14, 2021
@r-rmcgibbo

r-rmcgibbo commented May 14, 2021

Copy link
Copy Markdown

Result of nixpkgs-review pr 123026 at 4055fa2 run on aarch64-linux 1

1 package built successfully:
  • cd-hit
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/science/biology/cd-hit/default.nix:34:5:

       |
    34 |     license = licenses.gpl2;
       |     ^
    

Result of nixpkgs-review pr 123026 at 4055fa2 run on x86_64-linux 1

1 package built successfully:
  • cd-hit
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/science/biology/cd-hit/default.nix:34:5:

       |
    34 |     license = licenses.gpl2;
       |     ^
    

@veprbl

veprbl commented May 14, 2021

Copy link
Copy Markdown
Member

Upstream PR weizhongli/cdhit#114

@veprbl

veprbl commented May 14, 2021

Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 123026 run on x86_64-darwin 1

1 package built:
  • cd-hit

@veprbl veprbl merged commit 2adca7a into NixOS:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants