modern-cpp-kafka: init at 2023.03.07

[ditsuke]

Description of changes

Adds a derivation for modern-cpp-kafka.

NOTE
Using my fork that patches some cmake build setup temporarily. Won't be required once my PR
is accepted upstream. Alternatively I could apply my fixes as an inline-patch while still using the official repo.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[nagy]

Can you use the upstream version of this project anyway and add your patches via the patches ? Or, since your PR is still very young, maybe just wait a bit and see if they accept it.

[ditsuke]

The build won't work without it, but I've added it as a patch for now.

[nagy]

Calls to cmake, which is a configuration tool, do not belong into the buildPhase.
Do you intent to just provide the headers with this library, or do you also plan to ship compiled library files also? For only header files, you may not even need a configuration phase. But that should be handled by having cmake in nativeBuildInputs already.

[ditsuke]

Just the headers

[nagy]

Oh and one more thing, can you change the commit message ( and the PR title) to modern-cpp-kafka: init at 2023.03.07 ?

[nagy]

A few things are still left.

• The commit message ( and PR title) is still named "kakfa" instead of "kafka".

From here it gets pedantic, but we want to keep the commit history in a good quality:

• The commit message of the maintainership commit does not fit. You can find other good examples in the history of that file: https://github.com/NixOS/nixpkgs/commits/master/maintainers/maintainer-list.nix
• Therefore, the maintainership commit should be separate from any packages and you can just directly write it into the package commit itself.

After that it should be good to go.

[ditsuke]

A few things are still left.

* The commit message ( and PR title) is still named "kakfa" instead of "kafka".

From here it gets pedantic, but we want to keep the commit history in a good quality:

* The commit message of the maintainership commit does not fit. You can find other good examples in the history of that file: [`master`/maintainers/maintainer-list.nix (commits)](https://github.com/NixOS/nixpkgs/commits/master/maintainers/maintainer-list.nix)

* Therefore, the maintainership commit should be separate from any packages and you can just directly write it into the package commit itself.

After that it should be good to go.

@nagy split and reworded the maintainer commit, I hope it's good to go now

[nagy]

The commit message is still "kakfa" . After that, its good.

[ditsuke]

The commit message is still "kakfa" . After that, its good.

Whoops, sorry about that. Good to go

[wegank]

Result of nixpkgs-review pr 251825 run on aarch64-darwin 1

1 package built:

• modern-cpp-kafka