python313.pkgs.installer: Fix build

[jtojnar]

Description of changes

Python 3.13 removed importlib.resources.read_binary breaking the build of installer package.
That is transitive dependency of pygobject3 among others.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[mweinelt]

Interesting. Seems pretty early, we're not going to recurse into python313Packages for a while, but it is of course reasonable to allow playing with it.

That is transitive dependency of pygobject3 among others.

Hopefully not yet.

[jtojnar]

Relative path references are resolved relative to the Nix file they are within and evaluate to a path object that internally probably uses absolute path. Otherwise, we could not really use them in any Nix file that is imported anywhere else.

…

On Sat, Feb 10 2024 at 07:00:23 -08:00:00, Martin Weinelt ***@***.***> wrote: @mweinelt commented on this pull request. In pkgs/development/python-modules/bootstrap/installer/default.nix: > @@ -7,7 +7,7 @@ stdenv.mkDerivation { pname = "${python.libPrefix}-bootstrap-${installer.pname}"; - inherit (installer) version src meta; + inherit (installer) version src patches meta; Can't inherit it like that, because the path will be different. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[mweinelt]

Indeed, you just didn't commit the patch.

[jtojnar]

I meant that `pygobject3` depends on `installer`. So when I tried to build `python313.pkgs.pygobject3` to test pygobject/pygobject-stubs#167 with [PEP 702](https://peps.python.org/pep-0702/), it failed on installer depencency.

[jtojnar]

On Sat, Feb 10 2024 at 07:16:38 -08:00:00, Martin Weinelt ***@***.***> wrote: Indeed, you just didn't commit the patch.

Oops, fixed.