Skip to content

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented Mar 25, 2024

Description of changes

https://github.com/embree/embree/blob/master/CHANGELOG.md

cc @hodapp @gebner

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nim65s
Copy link
Contributor Author

nim65s commented Mar 25, 2024

Result of nixpkgs-review pr 298963 run on x86_64-linux 1

5 packages failed to build:
  • blender
  • blender-hip
  • openusd
  • python311Packages.openusd
  • python312Packages.openusd
1 package built:
  • embree

@nim65s nim65s marked this pull request as draft March 25, 2024 16:59
@nim65s
Copy link
Contributor Author

nim65s commented Mar 25, 2024

Let's wait a bit for PixarAnimationStudios/OpenUSD#2313 maybe

@ofborg ofborg bot requested review from Hodapp87 and gebner March 25, 2024 17:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 25, 2024
@nim65s nim65s mentioned this pull request Mar 26, 2024
13 tasks
@nim65s
Copy link
Contributor Author

nim65s commented Mar 27, 2024

nixpkgs-review is fixed in #299049 thanks to a patch on openusd for embree 4.
Therefore we might want to close this (#298963) in favor of #299049, I don't know.

};

patches = [
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused fetchpatch from inputs.

@nim65s
Copy link
Contributor Author

nim65s commented Apr 16, 2024

I think we can focus on #299049

@nim65s nim65s closed this Apr 16, 2024
@nim65s nim65s deleted the embree branch April 21, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants