bossa: fix build failure on Darwin with clang >= 15 #309519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See shumatech/BOSSA#172. Essentially, recent versions of macOS started shipping clang version above 15, which promoted the unqualified-std-cast-call warning into a hard error. Unfortunately, it seems like upstream is dormant as of now, so we have to apply the patch ourselves.
pluiedev
added
the
0.kind: ZHF Fixes
ofborg
bot
added
6.topic: darwin
Scrumplex
approved these changes
May 6, 2024
Member
Scrumplex
left a comment
Scrumplex
left a comment
There was a problem hiding this comment.
Builds and seems to work on aarch64-darwin
Scrumplex
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See shumatech/BOSSA#172. Essentially, recent versions of macOS started shipping clang version above 15, which promoted the
unqualified-std-cast-callwarning into a hard error.Unfortunately, it seems like upstream is dormant as of now, so we have to apply the patch ourselves.
This is part of the ongoing ZHF campaign for 24.05.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.