Skip to content

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python312Packages.materialx is: Open standard for representing rich material and look-development content in computer graphics

meta.homepage for python312Packages.materialx is: https://materialx.org

meta.changelog for python312Packages.materialx is: https://github.com/AcademySoftwareFoundation/MaterialX/blob/refs/tags/v1.39.0/CHANGELOG.md

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.39.0 with grep in /nix/store/qw5p5lyffd8fqbncnz8jcnz7jfmf0vc8-python3.12-materialx-1.39.0
  • found 1.39.0 in filename of file in /nix/store/qw5p5lyffd8fqbncnz8jcnz7jfmf0vc8-python3.12-materialx-1.39.0

Rebuild report (if merged into master) (click to expand)
9 total rebuild path(s)

9 package rebuild(s)

First fifty rebuilds by attrpath

blender
blender-hip
materialx
openusd
python311Packages.materialx
python311Packages.openusd
python312Packages.materialx
python312Packages.openusd
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qw5p5lyffd8fqbncnz8jcnz7jfmf0vc8-python3.12-materialx-1.39.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python312Packages.materialx https://github.com/r-ryantm/nixpkgs/archive/3af973f6a8eb435812b905079a26fd45f3a6714c.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/3af973f6a8eb435812b905079a26fd45f3a6714c#python312Packages.materialx

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qw5p5lyffd8fqbncnz8jcnz7jfmf0vc8-python3.12-materialx-1.39.0
ls -la /nix/store/qw5p5lyffd8fqbncnz8jcnz7jfmf0vc8-python3.12-materialx-1.39.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

5 packages failed to build:
  • blender
  • blender-hip
  • openusd
  • python311Packages.openusd
  • python312Packages.openusd
2 packages built:
  • materialx (python312Packages.materialx)
  • python311Packages.materialx

Maintainer pings

cc @gador for testing.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 12, 2024
@ofborg ofborg bot requested a review from gador July 12, 2024 05:40
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 12, 2024
@gador
Copy link
Member

gador commented Aug 16, 2024

This breaks downstream packages due to several errors in MaterialX cmake interface.
Using 1.39.1-rc1 with the following patch applied, works:

diff --git a/pkgs/development/python-modules/materialx/default.nix b/pkgs/development/python-modules/materialx/default.nix
index b1e11ba6de23..ff9f536c762a 100644
--- a/pkgs/development/python-modules/materialx/default.nix
+++ b/pkgs/development/python-modules/materialx/default.nix
@@ -12,19 +12,27 @@
   openimageio,
   imath,
   python,
+  fetchpatch2,
 }:

 buildPythonPackage rec {
   pname = "materialx";
-  version = "1.38.10";
+  version = "1.39.1-rc1";

   src = fetchFromGitHub {
     owner = "AcademySoftwareFoundation";
     repo = "MaterialX";
-    rev = "v${version}";
-    hash = "sha256-/kMHmW2dptZNtjuhE5s+jvPRIdtY+FRiVtMU+tiBgQo=";
+    rev = "refs/tags/v${version}";
+    hash = "sha256-xA91/QfBepO4E6i8sEC9jlcQMCPTK7wyiL2ztv4yzl8=";
   };

+  patches = [
+    (fetchpatch2 {
+      url = "https://patch-diff.githubusercontent.com/raw/AcademySoftwareFoundation/MaterialX/pull/1971.patch?full_index=1";
+      hash = "sha256-M2/uZgzmWwrPbeYY4/1YGS9LAbPZFmEB52XVao9cXbA=";
+    })
+  ];
+
   format = "other";

   nativeBuildInputs = [

Since this requires the rc-1 version and a patch, lets wait for upstream to release a bugfix release we can just use

@gador gador closed this Aug 16, 2024
@gador
Copy link
Member

gador commented Aug 16, 2024

Also downstream package openusd fails to build due to breaking API changes. An unmerged PR has been submitted: PixarAnimationStudios/OpenUSD#3159

@r-ryantm r-ryantm deleted the auto-update/python312Packages.materialx branch August 16, 2024 12:21
@gador gador mentioned this pull request Nov 3, 2024
13 tasks
gador added a commit to gador/nixpkgs that referenced this pull request Nov 3, 2024
This reverts commit 993ec32.
MaterialX has some upstream issues which haven't been quite
worked out, yet[1]. It is therefore reasonable to wait
with an update in nixpkgs. It also breaks downstream packages
like python312Packages.openusd as well as blender[2]

[1]: PixarAnimationStudios/OpenUSD#3159
[2]: NixOS#326466 (comment)

Signed-off-by: Florian Brandes <[email protected]>
gador added a commit to ShaddyDC/nixpkgs that referenced this pull request Nov 3, 2024
This reverts commit 993ec32.
MaterialX has some upstream issues which haven't been quite
worked out, yet[1]. It is therefore reasonable to wait
with an update in nixpkgs. It also breaks downstream packages
like python312Packages.openusd as well as blender[2]

[1]: PixarAnimationStudios/OpenUSD#3159
[2]: NixOS#326466 (comment)

Signed-off-by: Florian Brandes <[email protected]>
wentasah pushed a commit to wentasah/nixpkgs that referenced this pull request Nov 4, 2024
This reverts commit 993ec32.
MaterialX has some upstream issues which haven't been quite
worked out, yet[1]. It is therefore reasonable to wait
with an update in nixpkgs. It also breaks downstream packages
like python312Packages.openusd as well as blender[2]

[1]: PixarAnimationStudios/OpenUSD#3159
[2]: NixOS#326466 (comment)

Signed-off-by: Florian Brandes <[email protected]>
@gador gador mentioned this pull request Feb 8, 2025
3 tasks
gador added a commit to gador/nixpkgs that referenced this pull request Feb 8, 2025
This reverts commit e4d1e54.

This is necessary, because 1.39 introduces breaking changes and
downstream software (e.g. openUSD) needs to adapt, first.

See NixOS#326466 (comment)
and NixOS#380230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants