Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.langchain-chroma: fix broken tests #345803

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Oct 1, 2024

Description of changes

  1. Mark test_chroma_async as an async test. Not doing this was causing warnings and breaking the following test.
  2. Added sarahec as maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor Author

sarahec commented Oct 1, 2024

Patches around langchain-ai/langchain#27034

@sarahec
Copy link
Contributor Author

sarahec commented Oct 2, 2024

Upstream fix: langchain-ai/langchain#27037

@fabaff
Copy link
Member

fabaff commented Oct 2, 2024

Result of nixpkgs-review pr 345803 run on x86_64-linux 1

6 packages built:
  • open-webui
  • open-webui.dist
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit c163396 into NixOS:master Oct 2, 2024
28 of 29 checks passed
@sarahec sarahec deleted the langchain-core-darwin-fix branch October 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants