Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.langchain-chroma: disable broken test #346029

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Oct 2, 2024

Changes

  1. Disabled test_chroma_update_document

This is part of langchain-chroma's integration tests which are also broken in the source repo. Their makefile doesn't run these tests, so I have cause to believe they're unmaintained.

This particular test breaks the build unpredictability. (So flaky and broken!)

See discussion in #345372

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec sarahec requested a review from fabaff October 2, 2024 23:26
@ofborg ofborg bot requested a review from natsukium October 3, 2024 01:52
@drupol drupol changed the title python3Packages.langchain-chroma: disable broken test python312Packages.langchain-chroma: disable broken test Oct 3, 2024
@drupol
Copy link
Contributor

drupol commented Oct 3, 2024

@ofborg build python312Packages.langchain-chroma

@drupol drupol merged commit d52e0a7 into NixOS:master Oct 3, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants