nixos/kernel: Module inclusion improvements #375975
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
from
229a973 to
6e3eb2c
Compare
github-actions
bot
added
10.rebuild-darwin: 0
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
3 times, most recently
from
a82062e to
1afee75
Compare
github-actions
bot
added
6.topic: module system
ElvishJerricco
changed the title
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
from
1afee75 to
c1e25ec
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
|
Targeting staging-next as I believe this will rebuild all nixos tests. It could target staging for that reason, but it would take longer to hit master that way. staging-next does not build nixos tests, meaning all nixos tests are rebuilt when staging-next is merged into master, making staging-next the ideal target for changes that only rebuild all nixos tests. |
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
from
c1e25ec to
34677cd
Compare
github-actions
bot
added
the
8.has: documentation
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
from
34677cd to
adbced5
Compare
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
from
adbced5 to
d9a2459
Compare
ofborg
bot
added
the
2.status: merge conflict
roberth
reviewed
Mar 23, 2025
Comment on lines
+1165
to
+1184
| # A list of attrnames is coerced into an attrset of bools by | ||
| # setting the values to true. |
There was a problem hiding this comment.
Not to tempt contributors into improving this duplicate doc.
Suggested change
| # A list of attrnames is coerced into an attrset of bools by | |
| # setting the values to true. | |
| /** See https://nixos.org/manual/nixos/unstable/#sec-option-types-basic */ |
There was a problem hiding this comment.
I don't see any other types in this file linking to the manual like that?
Comment on lines
+11
to
+17
| modulesTypeDesc = '' | ||
| This can either be a list of modules, or an attrset. In an | ||
| attrset, names that are set to `true` represent modules that will | ||
| be included. Note that setting these names to `false` does not | ||
| prevent the module from being loaded. For that, use | ||
| {option}`boot.blacklistedKernelModules`. | ||
| ''; |
There was a problem hiding this comment.
Should it be coercedTo (... true) (attrsOf (enum [ true false "auto" ])) then?
There was a problem hiding this comment.
I don't understand. That isn't what these options do.
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
from
d9a2459 to
aece67d
Compare
ElvishJerricco
force-pushed
the
push-lsvukqwlwnqo
branch
from
aece67d to
987e813
Compare
ofborg
bot
removed
the
2.status: merge conflict
wegank
added
the
2.status: merge conflict
|
@roberth ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boot.initrd.allowMissingModules = trueto allow a system to build even when the kernel doesn't have all the requested modules. Orboot.availableKernelModules.foo = true;to enable / disable a module.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.