ruffle: nightly-2025-01-04 -> nightly-2025-01-25#376808
Merged
Conversation
Author
|
I can also submit a patch to remove GovanifY from |
Contributor
|
Contributor
|
jchv
approved these changes
Jan 28, 2025
Contributor
jchv
left a comment
There was a problem hiding this comment.
Tested on x86-64 Linux with Wayland and X11, tested on aarch64 Darwin. Diff LGTM.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to a simple version bump, I have significantly refactored the derivation for ruffle to resolve inconsistencies and add features.
For summary:
fetchFromGitHubto usetagand factored outpnamestdenvwithstdenvNoCCpostInstallruffle_desktopto justruffle.metafields to add more information.I don't have a Darwin machine, so that still requires testing (I'm not aware if changing the binary name affects MacOS), if everything looks good then I'll squash and rebase if needed.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.