Skip to content

nixos/oauth2-proxy-nginx: match files in location block exactly#382869

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:oauth2-proxy-location
Feb 17, 2025
Merged

nixos/oauth2-proxy-nginx: match files in location block exactly#382869
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:oauth2-proxy-location

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Feb 17, 2025

Based on feedback I got in dvershinin/gixy#15 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2025
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review February 17, 2025 17:26
@oddlama
Copy link
Member

oddlama commented Feb 17, 2025

Looks like I've had the same change in my local config for some time, so I can confirm this works.

@SuperSandro2000 SuperSandro2000 merged commit 1be5e52 into NixOS:master Feb 17, 2025
61 of 63 checks passed
@SuperSandro2000 SuperSandro2000 deleted the oauth2-proxy-location branch February 17, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants