-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Fix FreeBSD native stdenv again #389733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Fix FreeBSD native stdenv again #389733
Conversation
263f768
to
04ba72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes seem reasonable, but keep-libc is a weird thing to add with no explanation
04ba72b
to
8768016
Compare
Testing on my FreeBSD 14.2 VM, I'm still getting a test failure in diffutils ( |
This test relies on atime of files and fails inconsistently on FreeBSD.
This atime-based test fails on some FreeBSD configurations
Hey gamers it's ya gal Audrey here with another episode of "we need some CI on this derivation". This episode's sponsor is the nix-community builders, who generously offered to set me up with a machine to make sure this build stays building!
Most of these changes are fallout from splitting freebsd.libc into freebsd.libcMinimal + several other derivations. The rest are simply the march of time, rot and let rot.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.