Fix FreeBSD native stdenv again #389733
Merged
Fix FreeBSD native stdenv again #389733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: stdenv
rhelmot
force-pushed
the
freebsd-fix-again
branch
from
263f768 to
04ba72b
Compare
github-actions
bot
added
10.rebuild-darwin: 5001+
nix-owners
bot
requested review from
adevress,
amiloradovsky,
bjornfor,
edolstra and
prusnak
artemist
requested changes
Mar 14, 2025
Member
artemist
left a comment
artemist
left a comment
There was a problem hiding this comment.
Most of the changes seem reasonable, but keep-libc is a weird thing to add with no explanation
rhelmot
force-pushed
the
freebsd-fix-again
branch
from
04ba72b to
8768016
Compare
Member
|
Testing on my FreeBSD 14.2 VM, I'm still getting a test failure in diffutils ( |
wegank
added
the
2.status: merge conflict
This test relies on atime of files and fails inconsistently on FreeBSD.
This atime-based test fails on some FreeBSD configurations
rhelmot
force-pushed
the
freebsd-fix-again
branch
from
53ca6be to
9f3746c
Compare
ofborg
bot
removed
the
2.status: merge conflict
Pulls in a patch from freebsd-ports. This patch cannot be made unconditional without a rework since it modifies the base behavior.
rhelmot
force-pushed
the
freebsd-fix-again
branch
from
d481b90 to
8cf96ba
Compare
Contributor
Author
|
I just built this on systems with both ZFS and UFS filesystems. Should be ready to go. |
artemist
reviewed
May 31, 2025
Member
artemist
left a comment
artemist
left a comment
There was a problem hiding this comment.
There's only one thing I'm confused about. I'm building now, if that works I think it should be good to merge.
Copying instead of symlinking prevents leakage of the bootstrap FHS into the 0->1 bootstrap stage. The symptom this addresses is libssh2 failing because it can't find libssl, since it is failing to use the ld wrapper.
Fixes the boot0 build of python
rhelmot
force-pushed
the
freebsd-fix-again
branch
from
8cf96ba to
1a7421d
Compare
Member
|
The gdbm patch is actually upstream, so could probably have been applied unconditionally relatively safely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey gamers it's ya gal Audrey here with another episode of "we need some CI on this derivation". This episode's sponsor is the nix-community builders, who generously offered to set me up with a machine to make sure this build stays building!
Most of these changes are fallout from splitting freebsd.libc into freebsd.libcMinimal + several other derivations. The rest are simply the march of time, rot and let rot.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.