-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python313Packages.nanobind: disable check phase by default #393250
base: master
Are you sure you want to change the base?
Conversation
3923261
to
69eeeb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is more straightforward and common.
69eeeb6
to
9a7e82c
Compare
@GaetanLepage it does not seems to run the
|
9a7e82c
to
71c7544
Compare
71c7544
to
403b78e
Compare
403b78e
to
dca06b8
Compare
Thanks a lot for your contribution @Sigmanificient and for your review @GaetanLepage. I have to admit that I still have to learn about the "passthru" functionality. Just to be clear how to run the tests in the future (when I upgrade the version): do I have to run |
@phiadaarr Yes, you will have to run This pr is meant to reduce the dependencies for packages that use nanobind as a build system. It will avoid, for instance, to build |
Small precision: You can omit the |
nativeCheckInputs
dependencies can break children derivation #393248Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.