Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python313Packages.nanobind: disable check phase by default #393250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Mar 26, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is more straightforward and common.

@Sigmanificient Sigmanificient force-pushed the nanobind-disable-check branch from 69eeeb6 to 9a7e82c Compare March 27, 2025 17:51
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Mar 27, 2025

@GaetanLepage it does not seems to run the pytest suite on my side while building:

nix-build -A python3Packages.nanobind.passthru.tests.pytest

@Sigmanificient Sigmanificient force-pushed the nanobind-disable-check branch from 9a7e82c to 71c7544 Compare March 27, 2025 18:53
@Sigmanificient Sigmanificient force-pushed the nanobind-disable-check branch from 403b78e to dca06b8 Compare March 28, 2025 14:04
@phiadaarr
Copy link
Contributor

Thanks a lot for your contribution @Sigmanificient and for your review @GaetanLepage. I have to admit that I still have to learn about the "passthru" functionality. Just to be clear how to run the tests in the future (when I upgrade the version): do I have to run nix-build -A python3Packages.nanobind.passthru.tests.pytest or can I run nix-build -A python3Packages.nanobind as before or something else?

@Sigmanificient
Copy link
Member Author

@phiadaarr Yes, you will have to run nix-build -A python3Packages.nanobind.passthru.tests.pytest to enable the check phase.

This pr is meant to reduce the dependencies for packages that use nanobind as a build system. It will avoid, for instance, to build tensorflow which is part of nanobind nativeCheckInputs.

@GaetanLepage
Copy link
Contributor

@phiadaarr Yes, you will have to run nix-build -A python3Packages.nanobind.passthru.tests.pytest to enable the check phase.

This pr is meant to reduce the dependencies for packages that use nanobind as a build system. It will avoid, for instance, to build tensorflow which is part of nanobind nativeCheckInputs.

Small precision: You can omit the passthru and build all the test (which amounts to be the same here) in your command: nix-build -A python3Packages.nanobind.tests

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nanobind: nativeCheckInputs dependencies can break children derivation
4 participants