Skip to content

elfutils: 0.192 -> 0.193 #402441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

elfutils: 0.192 -> 0.193 #402441

wants to merge 1 commit into from
+10 −2

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Apr 28, 2025 •
edited
Loading

Changes: https://www.mail-archive.com/[email protected]/msg08098.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from r-burns April 28, 2025 06:13
@trofi trofi marked this pull request as draft April 28, 2025 06:17
@trofi
Copy link
Contributor Author

trofi commented Apr 28, 2025 •
edited
Loading

One new test lacks an rpath/ld_preload to run lcoally:

       > ./dwarf_srclang_check: error while loading shared libraries: libelf.so.1: cannot open shared object file: No such file or directory
       > FAIL dwarf_srclang_check (exit status: 127)

UPDATE: filed upstream as https://sourceware.org/PR32929

@trofi trofi force-pushed the elfutils-update branch from 67e9d70 to 1b8d38e Compare April 28, 2025 06:35
@trofi
Copy link
Contributor Author

trofi commented Apr 28, 2025

Added LD_LIBRARY_PATH to preCheck until it's fixed upstream.

@trofi trofi marked this pull request as ready for review April 28, 2025 06:36
@trofi trofi force-pushed the elfutils-update branch from 1b8d38e to 86b0198 Compare May 2, 2025 13:38
r-burns
r-burns approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds/runs on x86_64-linux

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trofi @r-burns @wegank