Skip to content

gn: 2168 -> 2223 (2024-05-03 -> 2025-03-21) #403859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

gn: 2168 -> 2223 (2024-05-03 -> 2025-03-21) #403859

wants to merge 1 commit into from

Conversation

pwaller
Copy link
Contributor

@pwaller pwaller commented May 3, 2025

Tested x86_64-linux, aarch64-linux, pkgsStatic.gn,
pkgsCross.aarch64-multiplatform.gn.

Signed-off-by: Peter Waller [email protected]

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pwaller pwaller changed the base branch from master to staging May 3, 2025 09:55
@pwaller
gn: 2168 -> 2223 (2024-05-03 -> 2025-03-21)
3de9ae0 
* Matches commit to chromium info.json https://github.com/NixOS/nixpkgs/blob/b686761047077698d9f22e3a9429a842dc045037/pkgs/applications/networking/browsers/chromium/info.json#L807
* Drops now unneeded patch.
* Use -Wno-format-security.
* Update chromium gn rev path comment to info.json.

Tested x86_64-linux, aarch64-linux, pkgsStatic.gn,
pkgsCross.aarch64-multiplatform.gn.

Signed-off-by: Peter Waller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pwaller